migrate RecoPixelVertexing/PixelLowPtUtilities to esConsumes #33121

mmusich · 2021-03-09T18:26:50Z

PR description:

Title says it all.
Part of #31061.
I migrated only the "easy" ones. Classes inheriting from base classes needing modifications outside of this package will have to be dealt with at a later time.

PR validation:

Run standard limited matrix validation:

runTheMatrix.py -l limited -j 8 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport needed

cmsbuild · 2021-03-09T18:32:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33121/21468

This PR adds an extra 28KB to repository

cmsbuild · 2021-03-09T18:33:06Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

RecoPixelVertexing/PixelLowPtUtilities

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2021-03-09T19:01:52Z

@cmsbuild, please test

cmsbuild · 2021-03-09T21:48:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-529e31/13383/summary.html
COMMIT: b5e1c2e
CMSSW: CMSSW_11_3_X_2021-03-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33121/13383/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2849195
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2849170
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 160 log files, 37 edm output root files, 38 DQM output files

jpata

Thanks a lot for this migration! I don't see any problem in the reco tests.

RecoPixelVertexing/PixelLowPtUtilities/plugins/PixelVertexProducerClusters.h

RecoPixelVertexing/PixelLowPtUtilities/interface/StripSubClusterShapeTrajectoryFilter.h

cmsbuild · 2021-03-15T12:49:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33121/21590

This PR adds an extra 20KB to repository

cmsbuild · 2021-03-15T12:49:44Z

Pull request #33121 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

VinInn · 2021-03-15T13:37:40Z

On 15 Mar, 2021, at 12:53 PM, Joosep Pata ***@***.***> wrote: In RecoPixelVertexing/PixelLowPtUtilities/plugins/PixelVertexProducerClusters.h: > #include "DataFormats/TrackerRecHit2D/interface/SiPixelRecHitCollection.h" +class TrackerGeometry; I think we don't allow forward declaring classes from other packages [1]. Was there a reason to not include the header? [1] (https://cms-sw.github.io/cms_coding_rules.html 4.7)

May I ask what's the rationale behind such a rule? v.

mmusich · 2021-03-15T15:25:04Z

@cmsbuild please test

jpata · 2021-03-15T15:41:20Z

May I ask what's the rationale behind such a rule? v.

perhaps @slava77 can clarify the reasoning behind this rule?

cmsbuild · 2021-03-15T16:41:12Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-529e31/13523/summary.html
COMMIT: 57b88a1
CMSSW: CMSSW_11_3_X_2021-03-14-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33121/13523/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

136.88811

----- Begin Fatal Exception 15-Mar-2021 16:44:46 CET-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://cms-xrd-global.cern.ch//store/data/Run2018D/JetHT/AOD/12Nov2019_UL2018-v4/110007/02F69212-64ED-6B4B-BAC4-D9C2D53C8C57.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2018D/JetHT/AOD/12Nov2019_UL2018-v4/110007/02F69212-64ED-6B4B-BAC4-D9C2D53C8C57.root
      [b] Input file root://cms-xrd-global.cern.ch//store/data/Run2018D/JetHT/AOD/12Nov2019_UL2018-v4/110007/02F69212-64ED-6B4B-BAC4-D9C2D53C8C57.root could not be opened.
      [c] XrdCl::File::Open(name='root://cms-xrd-global.cern.ch//store/data/Run2018D/JetHT/AOD/12Nov2019_UL2018-v4/110007/02F69212-64ED-6B4B-BAC4-D9C2D53C8C57.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [d] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2018D/JetHT/AOD/12Nov2019_UL2018-v4/110007/02F69212-64ED-6B4B-BAC4-D9C2D53C8C57.root?tried=&xrdcl.requuid=191b7357-9eaa-4e6c-9012-b5342d098a76
      [e] Problematic data server: cms-xrd-global.cern.ch:1094
      [f] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

slava77 · 2021-03-15T17:06:36Z

May I ask what's the rationale behind such a rule? v.

perhaps @slava77 can clarify the reasoning behind this rule?

please see cms-sw/cms-sw.github.io#94 (comment)
and related discussion in the thread.

mmusich · 2021-03-16T09:10:18Z

@cmsbuild, please test

cmsbuild · 2021-03-16T11:47:49Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-529e31/13537/summary.html
COMMIT: 57b88a1
CMSSW: CMSSW_11_3_X_2021-03-15-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33121/13537/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2635087
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2635062
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

jpata · 2021-03-16T14:25:32Z

+reconstruction

technical, migrates a number of classes in RecoPixelVertexing/PixelLowPtUtilities to esConsumes
no reco changes expected/observed

Thanks a lot for this PR!

cmsbuild · 2021-03-16T14:25:58Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-03-16T14:51:23Z

+1

cmsbuild added this to the CMSSW_11_3_X milestone Mar 9, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Mar 9, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 9, 2021

cmsbuild added tests-started and removed tests-pending labels Mar 9, 2021

cmsbuild added tests-approved and removed tests-started labels Mar 9, 2021

jpata reviewed Mar 15, 2021

View reviewed changes

migrate RecoPixelVertexing/PixelLowPtUtilities to esConsumes

57b88a1

mmusich force-pushed the migrateRecoPixelVertexingPixelLowPtUtilitiesToEsConsumes branch from b5e1c2e to 57b88a1 Compare March 15, 2021 12:41

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-approved labels Mar 15, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 15, 2021

cmsbuild removed the tests-pending label Mar 15, 2021

cmsbuild added the tests-started label Mar 15, 2021

cmsbuild added tests-rejected and removed tests-started labels Mar 15, 2021

cmsbuild added tests-started and removed tests-rejected labels Mar 16, 2021

cmsbuild added tests-approved and removed tests-started labels Mar 16, 2021

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Mar 16, 2021

cmsbuild added orp-approved and removed orp-pending labels Mar 16, 2021

cmsbuild merged commit f5e85a5 into cms-sw:master Mar 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

migrate RecoPixelVertexing/PixelLowPtUtilities to esConsumes #33121

migrate RecoPixelVertexing/PixelLowPtUtilities to esConsumes #33121

mmusich commented Mar 9, 2021

cmsbuild commented Mar 9, 2021

cmsbuild commented Mar 9, 2021

mmusich commented Mar 9, 2021

cmsbuild commented Mar 9, 2021

jpata left a comment

cmsbuild commented Mar 15, 2021

cmsbuild commented Mar 15, 2021

VinInn commented Mar 15, 2021 via email

mmusich commented Mar 15, 2021

jpata commented Mar 15, 2021

cmsbuild commented Mar 15, 2021

slava77 commented Mar 15, 2021

mmusich commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

jpata commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

qliphy commented Mar 16, 2021

migrate RecoPixelVertexing/PixelLowPtUtilities to esConsumes #33121

migrate RecoPixelVertexing/PixelLowPtUtilities to esConsumes #33121

Conversation

mmusich commented Mar 9, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Mar 9, 2021

cmsbuild commented Mar 9, 2021

mmusich commented Mar 9, 2021

cmsbuild commented Mar 9, 2021

Comparison Summary

jpata left a comment

Choose a reason for hiding this comment

cmsbuild commented Mar 15, 2021

cmsbuild commented Mar 15, 2021

VinInn commented Mar 15, 2021 via email

mmusich commented Mar 15, 2021

jpata commented Mar 15, 2021

cmsbuild commented Mar 15, 2021

RelVals

slava77 commented Mar 15, 2021

mmusich commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

Comparison Summary

jpata commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

qliphy commented Mar 16, 2021