You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We could use edm::ParameterSet::get*Parameter<std::optional<>> as a replacement for existsAs. The idea would be the fillDescriptions would add something special internal to the edm::ParameterSet for an optional that does not contain a default. Then only if that optional was declared in the fillDescriptions does the edm::ParameterSet::get*Parameter<std::optional<>> not throw if called. This fixes a problem with existsAs if one happens to have a typo using the wrong class type or wrong parameter name.
The text was updated successfully, but these errors were encountered:
@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks
Dr15Jones
changed the title
Replace ParameterSet::existAs with ParameterSet::get*Parameter<std::optional<...>>
[RFC] Replace ParameterSet::existAs with ParameterSet::get*Parameter<std::optional<...>>
Sep 19, 2024
We could use
edm::ParameterSet::get*Parameter<std::optional<>>
as a replacement forexistsAs
. The idea would be thefillDescriptions
would add something special internal to theedm::ParameterSet
for an optional that does not contain a default. Then only if that optional was declared in thefillDescriptions
does theedm::ParameterSet::get*Parameter<std::optional<>>
not throw if called. This fixes a problem withexistsAs
if one happens to have a typo using the wrong class type or wrong parameter name.The text was updated successfully, but these errors were encountered: