Old L1T tags consumed in DQM modules #37016

tvami · 2022-02-21T17:31:42Z

This is the main CMSSW version of
cms-l1t-offline#958
now focusing on the DQM packages.

As of now the following packages were identified to use (very possibly) deprecated L1T records. The list might be updated in the future.

Possible Group	Module	Record	Removed Tag
DQM/JetMET	METAnalyzer	L1GtTriggerMenuRcd	L1GtTriggerMenu_CRAFT09_hlt
DQM/JetMET	JetAnalyzer	L1GtTriggerMenuRcd	L1GtTriggerMenu_CRAFT09_hlt
DQM/BPH	BPHMonitor	L1GtStableParametersRcd	L1GtStableParameters_CRAFT09_hlt
DQM/Strips	SiStripMonitorCluster	L1GtStableParametersRcd	L1GtStableParameters_CRAFT09_hlt
DQM/Muons	MuonMonitor	L1GtStableParametersRcd	L1GtStableParameters_CRAFT09_hlt

tvami · 2022-02-21T17:31:53Z

assign dqm

cmsbuild · 2022-02-21T17:32:02Z

New categories assigned: dqm

@jfernan2,@ahmad3213,@rvenditti,@emanueleusai,@pbo0,@pmandrik you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2022-02-21T17:32:03Z

A new Issue was created by @tvami Tamas Vami.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

tvami · 2022-02-21T17:32:29Z

Hi @cms-sw/dqm-l2 friends,
Could you please assign the relevant subsystem DQM experts?
Thanks!

tvami · 2022-02-21T17:34:19Z

This PR #36986 might be helpful in how to handle the situation (that was for a different record)

tvami · 2022-02-21T17:36:06Z

Hi @arossi83 @sroychow could you please have a look at why SiStripMonitorCluster is accessing the L1GtStableParametersRcd?

mmusich · 2022-02-22T08:27:30Z

@tvami
SiStripMonitorCluster is NOT accessing directly L1GtStableParametersRcd as a very quick search in DXR will demonstrate to you: https://cmssdt.cern.ch/dxr/CMSSW/search?q=L1GtStableParametersRcd&case=true.
On the other hand, L1GtTriggerMenuRcd does (since it's a dependent record on L1GtStableParametersRcd):

cmssw/CondFormats/DataRecord/interface/L1GtTriggerMenuRcd.h

Lines 32 to 36 in 95eed0c

    
           class L1GtTriggerMenuRcd : public edm::eventsetup::DependentRecordImplementation< 
        
                                          L1GtTriggerMenuRcd, 
        
                                          edm::mpl::Vector<L1GtStableParametersRcd, L1TriggerKeyListRcd, L1TriggerKeyRcd> > { 
        
             // empty 
        
           };

and that in turn is consumed in GenericTriggerEventFlag

cmssw/CommonTools/TriggerUtils/src/GenericTriggerEventFlag.cc

Lines 135 to 137 in 81ade48

    
           if (onL1_ && !stage2_) { 
        
             l1GtTriggerMenuToken_ = iC.esConsumes<L1GtTriggerMenu, L1GtTriggerMenuRcd, edm::Transition::BeginRun>(); 
        
           }

and this object is finally constructed in SiStripMonitorCluster in:

cmssw/DQM/SiStripMonitorCluster/src/SiStripMonitorCluster.cc

Lines 63 to 68 in 95eed0c

    
           genTriggerEventFlagBPTXfilter_ = 
        
               new GenericTriggerEventFlag(iConfig.getParameter<edm::ParameterSet>("BPTXfilter"), consumesCollector(), *this); 
        
           genTriggerEventFlagPixelDCSfilter_ = new GenericTriggerEventFlag( 
        
               iConfig.getParameter<edm::ParameterSet>("PixelDCSfilter"), consumesCollector(), *this); 
        
           genTriggerEventFlagStripDCSfilter_ = new GenericTriggerEventFlag( 
        
               iConfig.getParameter<edm::ParameterSet>("StripDCSfilter"), consumesCollector(), *this);

In summary, if you want to loose the dependency on that record, you should not ask the DQM people, but rather either the HLT (as responsibles of CommonTools/TriggerUtils or the L1T for the record L1GtTriggerMenuRcd).
Finally please notice that in the GenericTriggerEventFlag the consumes is encapsulated in a statement regarding it begin stage1 (pre 2016), so the dependency seems legit to me.

tvami · 2022-02-22T13:51:06Z

Hi @mmusich thanks a lot for looking into this. I see that https://github.com/cms-sw/cmssw/blob/master/DQM/SiStripMonitorClient/python/pset4GenericTriggerEventFlag_cfi.py doesnt have the stage2 boolean on true (and the default is false), so I guess that's the cause of the problem.

tvami · 2022-02-22T13:57:29Z

assign hlt

tvami · 2022-02-22T13:57:38Z

unassign dqm

cmsbuild · 2022-02-22T13:57:50Z

New categories assigned: hlt

@missirol,@Martin-Grunewald you have been requested to review this Pull request/Issue and eventually sign? Thanks

mmusich · 2022-02-22T13:59:36Z

doesnt have the stage2 boolean on true (and the default is false), so I guess that's the cause of the problem.

right, probably one just needs to change here (and everywhere else that objected is used) the default for stage2 using the process modifier.

tvami · 2022-02-22T14:00:46Z

Hi @missirol can you make this modification that if the stage-2 era is used then

cmssw/CommonTools/TriggerUtils/src/GenericTriggerEventFlag.cc

Line 102 in 81ade48

if (config.exists("stage2"))

is set to true? I think it's better to do this at the source here instead of each single module that's using this flag, do you agree?

missirol · 2022-02-22T14:18:15Z

Based on https://github.com/cms-sw/cmssw/pull/28592/files#r358835228 , my understanding is that the default value of stage2 should be false as it already is in GenericTriggerEventFlag, so I don't see any change to be applied to the latter (other than eventually use fillDescriptions, but that's purely technical); the cpp class has to handle both cases, is configurable, and defaults to stage2=false.

right, probably one just needs to change here (and everywhere else that objected is used) the default for stage2 using the process modifier.

I would follow this approach, and if i understand Marco's comment, this means changing the python configuration of all the relevant DQM modules with the relevant modifier (that code is mostly under DQM, I think).

tvami · 2022-02-22T14:28:57Z

I was not suggesting to modify the cc code, I was suggesting to have a cff file that changes stage2 to true if the stage2L1Trigger era is used, something like

from Configuration.Eras.Modifier_stage2L1Trigger_cff import stage2L1Trigger
stage2L1Trigger.toModify(GenericTriggerEventFlag, stage2 = true)

Do you think that's a possible solution?

missirol · 2022-02-22T14:49:56Z

Yes, sure. The problem is that I don't see a central cfi for the PSet of GenericTriggerEventFlag. One way would be to have that cfi, it would contain the proc-modifier call as you wrote, and all the client modules would clone from that. Instead, it looks like these modules are creating this PSet from "scratch". So to me, this still makes it a client problem (iow, "assign dqm"). If you'd like me to look more into the details, it would be helpful to suggest a timeline ("by pre6?").

mmusich · 2022-02-22T15:13:07Z

@tvami
as far as I can tell one of the GenericTriggerEventFlag is already been taken care of here:

cmssw/DQM/SiStripMonitorClient/python/SiStripSourceConfigTier0_cff.py

Lines 71 to 79 in 69c0b83

    
           from Configuration.Eras.Modifier_stage2L1Trigger_cff import stage2L1Trigger 
        
           stage2L1Trigger.toModify(SiStripMonitorClusterBPTX,  
        
               BPTXfilter = dict( 
        
                   stage2 = cms.bool(True), 
        
                   l1tAlgBlkInputTag = cms.InputTag("gtStage2Digis"), 
        
                   l1tExtBlkInputTag = cms.InputTag("gtStage2Digis"), 
        
                   ReadPrescalesFromFile = cms.bool(True) 
        
               ) 
        
           )

I guess one just needs to adjust the other ones...
How can one check if the dependency is lost after the changes?

tvami · 2022-02-22T15:19:00Z

Here is what we've been using

runTheMatrix.py --what standard -l 138.4 --command "--conditions 121X_dataRun3_L1TriggerTagRemoval_v1 -n 1000" -t 8

Sorry it's in 121X, the whole cleaning started back then...

mmusich · 2022-02-22T15:48:42Z

OK.
I think this should solve:

diff --git a/DQM/SiStripMonitorClient/python/SiStripSourceConfigTier0_cff.py b/DQM/SiStripMonitorClient/python/SiStripSourceConfigTier0_cff.py
index 2e7fd85237c..6cfd463b334 100644
--- a/DQM/SiStripMonitorClient/python/SiStripSourceConfigTier0_cff.py
+++ b/DQM/SiStripMonitorClient/python/SiStripSourceConfigTier0_cff.py
@@ -75,7 +75,9 @@ stage2L1Trigger.toModify(SiStripMonitorClusterBPTX,
         l1tAlgBlkInputTag = cms.InputTag("gtStage2Digis"),
         l1tExtBlkInputTag = cms.InputTag("gtStage2Digis"),
         ReadPrescalesFromFile = cms.bool(True)
-    )
+    ),
+    PixelDCSfilter = dict(stage2 = cms.bool(True)),
+    StripDCSfilter = dict(stage2 = cms.bool(True))
 )
 
 # refitter ### (FIXME rename, move)
diff --git a/DQMOffline/Trigger/python/BPHMonitor_cfi.py b/DQMOffline/Trigger/python/BPHMonitor_cfi.py
index 71dab23a1a8..5f1bab34a06 100644
--- a/DQMOffline/Trigger/python/BPHMonitor_cfi.py
+++ b/DQMOffline/Trigger/python/BPHMonitor_cfi.py
@@ -4,9 +4,6 @@ from DQMOffline.Trigger.bphMonitoring_cfi import bphMonitoring as _bphMonitoring
 
 hltBPHmonitoring = _bphMonitoring.clone()
 
-from Configuration.Eras.Modifier_stage2L1Trigger_cff import stage2L1Trigger
-stage2L1Trigger.toModify(hltBPHmonitoring, stageL1Trigger = 2)
-
 #hltBPHmonitoring.options = cms.untracked.PSet(
 #    SkipEvent = cms.untracked.vstring('ProductNotFound')
 #)
@@ -117,3 +114,9 @@ hltBPHmonitoring.denGenericTriggerEventPSet.hltPaths  = cms.vstring( "HLT_Mu7p5_
 hltBPHmonitoring.denGenericTriggerEventPSet.andOrDcs      = cms.bool( False )
 hltBPHmonitoring.denGenericTriggerEventPSet.errorReplyDcs = cms.bool( True )
 hltBPHmonitoring.denGenericTriggerEventPSet.verbosityLevel = cms.uint32(0)
+
+from Configuration.Eras.Modifier_stage2L1Trigger_cff import stage2L1Trigger
+stage2L1Trigger.toModify(hltBPHmonitoring,
+                         stageL1Trigger = 2,
+                         numGenericTriggerEventPSet = dict(stage2 = cms.bool(True)),
+                         denGenericTriggerEventPSet = dict(stage2 = cms.bool(True)))
diff --git a/DQMOffline/Trigger/python/JetMonitor_cfi.py b/DQMOffline/Trigger/python/JetMonitor_cfi.py
index 932838c5344..b0c5447e221 100644
--- a/DQMOffline/Trigger/python/JetMonitor_cfi.py
+++ b/DQMOffline/Trigger/python/JetMonitor_cfi.py
@@ -39,3 +39,7 @@ hltJetMETmonitoring.denGenericTriggerEventPSet.andOrDcs      = cms.bool( False )
 hltJetMETmonitoring.denGenericTriggerEventPSet.errorReplyDcs = cms.bool( True )
 hltJetMETmonitoring.denGenericTriggerEventPSet.verbosityLevel = cms.uint32(1)
 
+from Configuration.Eras.Modifier_stage2L1Trigger_cff import stage2L1Trigger
+stage2L1Trigger.toModify(hltJetMETmonitoring,
+                         numGenericTriggerEventPSet = dict(stage2 = cms.bool(True)),
+                         denGenericTriggerEventPSet = dict(stage2 = cms.bool(True)))
diff --git a/DQMOffline/Trigger/python/METMonitor_cfi.py b/DQMOffline/Trigger/python/METMonitor_cfi.py
index 8f72ba6acc0..be521b4aad8 100644
--- a/DQMOffline/Trigger/python/METMonitor_cfi.py
+++ b/DQMOffline/Trigger/python/METMonitor_cfi.py
@@ -37,3 +37,8 @@ hltMETmonitoring.denGenericTriggerEventPSet.errorReplyDcs = cms.bool( True )
 hltMETmonitoring.denGenericTriggerEventPSet.verbosityLevel = cms.uint32(1)
 #hltMETmonitoring.denGenericTriggerEventPSet.hltPaths      = cms.vstring("HLT_IsoMu27_v*");
 hltMETmonitoring.denGenericTriggerEventPSet.hltPaths      = cms.vstring();
+
+from Configuration.Eras.Modifier_stage2L1Trigger_cff import stage2L1Trigger
+stage2L1Trigger.toModify(hltMETmonitoring,
+                         numGenericTriggerEventPSet = dict(stage2 = cms.bool(True)),
+                         denGenericTriggerEventPSet = dict(stage2 = cms.bool(True)))
diff --git a/DQMOffline/Trigger/python/MuonMonitor_cfi.py b/DQMOffline/Trigger/python/MuonMonitor_cfi.py
index 93c16eb01c4..cfc74964fc9 100644
--- a/DQMOffline/Trigger/python/MuonMonitor_cfi.py
+++ b/DQMOffline/Trigger/python/MuonMonitor_cfi.py
@@ -39,3 +39,8 @@ hltMuonmonitoring.denGenericTriggerEventPSet.andOrDcs      = cms.bool( False )
 hltMuonmonitoring.denGenericTriggerEventPSet.errorReplyDcs = cms.bool( True )
 hltMuonmonitoring.denGenericTriggerEventPSet.verbosityLevel = cms.uint32(1)
 
+from Configuration.Eras.Modifier_stage2L1Trigger_cff import stage2L1Trigger
+stage2L1Trigger.toModify(hltMuonmonitoring,
+                         numGenericTriggerEventPSet = dict(stage2 = cms.bool(True)),
+                         denGenericTriggerEventPSet = dict(stage2 = cms.bool(True)))
+

I don't want to own a PR about it and have no time to test it, but @tvami or @panoskatsoulis feel free to check it if works for you

tvami · 2022-02-22T15:59:15Z

Thanks Marco, I can submit the PR

missirol · 2022-02-22T15:59:23Z

unassign hlt

tvami · 2022-02-22T15:59:35Z

assign dqm

cmsbuild · 2022-02-22T15:59:55Z

New categories assigned: dqm

@jfernan2,@ahmad3213,@rvenditti,@emanueleusai,@pbo0,@pmandrik you have been requested to review this Pull request/Issue and eventually sign? Thanks

tvami · 2022-02-22T16:00:55Z

Yes, sure. The problem is that I don't see a central cfi for the PSet of GenericTriggerEventFlag. One way would be to have that cfi, it would contain the proc-modifier call as you wrote, and all the client modules would clone from that. Instead, it looks like these modules are creating this PSet from "scratch". So to me, this still makes it a client problem (iow, "assign dqm"). If you'd like me to look more into the details, it would be helpful to suggest a timeline ("by pre6?").

Maybe this can be added to a long term development with the fillDescription method, thanks!

missirol · 2022-02-22T17:59:45Z

I'm afraid Marco's patch might not be enough (hopefully i'm wrong).

The reason is that those (HLT-)DQM modules do have fillDescriptions, and those try to "guess" the parameters used inside GenericTriggerEventFlag (the latter unfortunately does not have its own fillPSetDescription to properly encapsulate things, as we were saying) .. and stage2 is not listed as an allowed parameter in the DQM modules' fillDescriptions. Example:

cmssw/DQMOffline/Trigger/plugins/BPHMonitor.cc

Lines 1247 to 1265 in 69c0b83

    
           edm::ParameterSetDescription genericTriggerEventPSet; 
        
           genericTriggerEventPSet.add<bool>("andOr"); 
        
           genericTriggerEventPSet.add<edm::InputTag>("dcsInputTag", edm::InputTag("scalersRawToDigi")); 
        
           genericTriggerEventPSet.add<edm::InputTag>("hltInputTag", edm::InputTag("TriggerResults::HLT")); 
        
           genericTriggerEventPSet.add<std::vector<int>>("dcsPartitions", {}); 
        
           genericTriggerEventPSet.add<bool>("andOrDcs", false); 
        
           genericTriggerEventPSet.add<bool>("errorReplyDcs", true); 
        
           genericTriggerEventPSet.add<std::string>("dbLabel", ""); 
        
           genericTriggerEventPSet.add<bool>("andOrHlt", true); 
        
           genericTriggerEventPSet.add<bool>("andOrL1", true); 
        
           genericTriggerEventPSet.add<std::vector<std::string>>("hltPaths", {}); 
        
           genericTriggerEventPSet.add<std::vector<std::string>>("l1Algorithms", {}); 
        
           genericTriggerEventPSet.add<std::string>("hltDBKey", ""); 
        
           genericTriggerEventPSet.add<bool>("errorReplyHlt", false); 
        
           genericTriggerEventPSet.add<bool>("errorReplyL1", true); 
        
           genericTriggerEventPSet.add<bool>("l1BeforeMask", true); 
        
           genericTriggerEventPSet.add<unsigned int>("verbosityLevel", 0); 
        
           desc.add<edm::ParameterSetDescription>("numGenericTriggerEventPSet", genericTriggerEventPSet); 
        
           desc.add<edm::ParameterSetDescription>("denGenericTriggerEventPSet", genericTriggerEventPSet);

so I would expect the framework to object to the last two lines of

+stage2L1Trigger.toModify(hltBPHmonitoring,
+                         stageL1Trigger = 2,
+                         numGenericTriggerEventPSet = dict(stage2 = cms.bool(True)),
+                         denGenericTriggerEventPSet = dict(stage2 = cms.bool(True)))

The bottom line is that some fillDescriptions cleanup in the cpp source code is likely needed.

tvami · 2022-02-22T18:23:12Z

Yes, seems like you are right @missirol
#37033 (comment)

missirol · 2022-02-22T18:36:38Z

A quick workaround would be to add stage2 to the fillDescriptions of those 2/3 HLT-DQM plugins (anyways, that's a DQM package, so not really up to me to comment).

jfernan2 · 2022-02-24T18:15:38Z

+1
For the records

cmsbuild · 2022-02-24T18:15:52Z

This issue is fully signed and ready to be closed.

mmusich · 2022-03-02T09:32:02Z

In light of cms-l1t-offline#958 (comment), I believe this issue has been closed too early.
I think at least this change would be still needed (not sure if there is a smarter way of using the modifiers for VPsets):

diff --git a/DQMOffline/JetMET/python/metDQMConfig_cfi.py b/DQMOffline/JetMET/python/metDQMConfig_cfi.py
index 4711c9ab286..b226e0cfabd 100644
--- a/DQMOffline/JetMET/python/metDQMConfig_cfi.py
+++ b/DQMOffline/JetMET/python/metDQMConfig_cfi.py
@@ -55,6 +55,10 @@ caloMetDQMAnalyzer = DQMEDAnalyzer('METAnalyzer',
         hltPaths       = cms.vstring( 'HLT_PFJet450_v*' ), 
         andOrHlt       = cms.bool( True ),
         errorReplyHlt  = cms.bool( False ),
+        stage2 = cms.bool(False),
+        l1tAlgBlkInputTag = cms.InputTag("gtStage2Digis"),
+        l1tExtBlkInputTag = cms.InputTag("gtStage2Digis"),
+        ReadPrescalesFromFile = cms.bool(False),
     ),
     cms.PSet(label = cms.string('lowPtJet'),
         andOr         = cms.bool( False ),     #True -> OR #Comment this line to turn OFF
@@ -64,6 +68,10 @@ caloMetDQMAnalyzer = DQMEDAnalyzer('METAnalyzer',
         hltPaths       = cms.vstring( 'HLT_PFJet80_v*' ), 
         andOrHlt       = cms.bool( True ),
         errorReplyHlt  = cms.bool( True ),
+        stage2 = cms.bool(False),
+        l1tAlgBlkInputTag = cms.InputTag("gtStage2Digis"),
+        l1tExtBlkInputTag = cms.InputTag("gtStage2Digis"),
+        ReadPrescalesFromFile = cms.bool(False),
     ),
     cms.PSet(label = cms.string('zeroBias'),
         andOr         = cms.bool( False ),     #True -> OR #Comment this line to turn OFF
@@ -73,6 +81,10 @@ caloMetDQMAnalyzer = DQMEDAnalyzer('METAnalyzer',
         hltPaths       = cms.vstring( 'HLT_ZeroBias_v*' ), 
         andOrHlt       = cms.bool( True ),
         errorReplyHlt  = cms.bool( False ),
+        stage2 = cms.bool(False),
+        l1tAlgBlkInputTag = cms.InputTag("gtStage2Digis"),
+        l1tExtBlkInputTag = cms.InputTag("gtStage2Digis"),
+        ReadPrescalesFromFile = cms.bool(False),
     ),
     cms.PSet(label = cms.string('highMET'),
         andOr         = cms.bool( False ),     #True -> OR #Comment this line to turn OFF
@@ -82,6 +94,10 @@ caloMetDQMAnalyzer = DQMEDAnalyzer('METAnalyzer',
         hltPaths       = cms.vstring( 'HLT_MET250_v*' ), 
         andOrHlt       = cms.bool( True ),
         errorReplyHlt  = cms.bool( False ),
+        stage2 = cms.bool(False),
+        l1tAlgBlkInputTag = cms.InputTag("gtStage2Digis"),
+        l1tExtBlkInputTag = cms.InputTag("gtStage2Digis"),
+        ReadPrescalesFromFile = cms.bool(False),
     ),
     #cms.PSet(label = cms.string('singleEle'),
     #    andOr         = cms.bool( False ),     #True -> OR #Comment this line to turn OFF
@@ -100,6 +116,10 @@ caloMetDQMAnalyzer = DQMEDAnalyzer('METAnalyzer',
         hltPaths       = cms.vstring( 'HLT_IsoMu24_eta2p1_v*', 'HLT_IsoMu27_v*'), 
         andOrHlt       = cms.bool( True ),
         errorReplyHlt  = cms.bool( False ),
+        stage2 = cms.bool(False),
+        l1tAlgBlkInputTag = cms.InputTag("gtStage2Digis"),
+        l1tExtBlkInputTag = cms.InputTag("gtStage2Digis"),
+        ReadPrescalesFromFile = cms.bool(False),
     ) 
     ),
  
@@ -132,6 +152,33 @@ caloMetDQMAnalyzer = DQMEDAnalyzer('METAnalyzer',
     ),
 )
 
+#
+# Make changes if using the Stage 2 trigger
+#
+from Configuration.Eras.Modifier_stage2L1Trigger_cff import stage2L1Trigger
+stage2L1Trigger.toModify(caloMetDQMAnalyzer,
+                         triggerSelectedSubFolders = {
+                             0:dict(stage2 = cms.bool(True),
+                                    l1tAlgBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    l1tExtBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    ReadPrescalesFromFile = cms.bool(True)),
+                             1:dict(stage2 = cms.bool(True),
+                                    l1tAlgBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    l1tExtBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    ReadPrescalesFromFile = cms.bool(True)),
+                             2:dict(stage2 = cms.bool(True),
+                                    l1tAlgBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    l1tExtBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    ReadPrescalesFromFile = cms.bool(True)),
+                             3:dict(stage2 = cms.bool(True),
+                                    l1tAlgBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    l1tExtBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    ReadPrescalesFromFile = cms.bool(True)),
+                             4:dict(stage2 = cms.bool(True),
+                                    l1tAlgBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    l1tExtBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    ReadPrescalesFromFile = cms.bool(True))})
+
 pfMetDQMAnalyzer = caloMetDQMAnalyzer.clone(
     METType = 'pf',
     METCollectionLabel     = "pfMet",

but the real problem is that METAnalyzer is consuming directly L1GtTriggerMenuRcd:

cmssw/DQMOffline/JetMET/src/METAnalyzer.cc

Line 1183 in 4eccbd2

const L1GtTriggerMenu* menu = &iSetup.getData(l1gtTrigMenuToken_);

I am not sure how exactly the code should be adapted in the case of the stage-2, but if that record is really obsolete, it is probably not doing anything useful currently.
In any case it would be something that a JME DQM expert should solve.

jfernan2 · 2022-03-02T10:24:26Z

@iatakisi @ramankhurana @physicist87 @bobaekim @pallabidas could you please advice in the issue above?
Thanks

ramankhurana · 2022-03-02T11:41:13Z

Thanks for notice, but I am not responsible for this anymore (from last 4 years).

makortel · 2022-03-02T14:15:53Z

(not sure if there is a smarter way of using the modifiers for VPsets):

+                          triggerSelectedSubFolders = {
+                             0:dict(stage2 = cms.bool(True),
+                                    l1tAlgBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    l1tExtBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    ReadPrescalesFromFile = cms.bool(True)),
+                             1:dict(stage2 = cms.bool(True),
+                                    l1tAlgBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    l1tExtBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    ReadPrescalesFromFile = cms.bool(True)),
+                             2:dict(stage2 = cms.bool(True),
+                                    l1tAlgBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    l1tExtBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    ReadPrescalesFromFile = cms.bool(True)),
+                             3:dict(stage2 = cms.bool(True),
+                                    l1tAlgBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    l1tExtBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    ReadPrescalesFromFile = cms.bool(True)),
+                             4:dict(stage2 = cms.bool(True),
+                                    l1tAlgBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    l1tExtBlkInputTag = cms.InputTag("gtStage2Digis"),
+                                    ReadPrescalesFromFile = cms.bool(True))})

I think this part could be expressed as something along

triggerSelectedSubFolders = {i: dict(stage2 = True,
    l1tAlgBlkInputTag = "gtStage2Digis",
    l1tExtBlkInputTag = "gtStage2Digis",
    ReadPrescalesFromFile = True) for i in range(0, len(caloMetDQMAnalyzer.triggerSelectedSubFolders))}

I tested as far as the dictionary comprehension produces the same dictionary as above (except here I dropped the explicit types from the "right hand side" as they seemed unnecessary(?)).

cmsbuild added dqm-pending pending-signatures labels Feb 21, 2022

tvami mentioned this issue Feb 21, 2022

Cleanning up depricating L1 O2O Tags from the CondDB cms-l1t-offline/cmssw#958

Open

cmsbuild added hlt-pending and removed dqm-pending labels Feb 22, 2022

cmsbuild added pending-assignment and removed hlt-pending pending-signatures labels Feb 22, 2022

cmsbuild added dqm-pending pending-signatures and removed pending-assignment labels Feb 22, 2022

tvami mentioned this issue Feb 22, 2022

Change DQM modules to use stage-2 L1T #37033

Merged

cmsbuild closed this as completed in #37033 Feb 24, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Feb 24, 2022

mmusich mentioned this issue Feb 28, 2022

introduce GenericTriggerEventFlag::fillPSetDescription and use it in several clients #37083

Merged

mmusich mentioned this issue Mar 22, 2022

loose indirect dependency on obsolete stage-1 L1T records in DQMOffline/JetMET #37310

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Old L1T tags consumed in DQM modules #37016

Old L1T tags consumed in DQM modules #37016

tvami commented Feb 21, 2022

tvami commented Feb 21, 2022

cmsbuild commented Feb 21, 2022

cmsbuild commented Feb 21, 2022

tvami commented Feb 21, 2022

tvami commented Feb 21, 2022

tvami commented Feb 21, 2022

mmusich commented Feb 22, 2022

tvami commented Feb 22, 2022

tvami commented Feb 22, 2022

tvami commented Feb 22, 2022

cmsbuild commented Feb 22, 2022

mmusich commented Feb 22, 2022

tvami commented Feb 22, 2022

missirol commented Feb 22, 2022

tvami commented Feb 22, 2022

missirol commented Feb 22, 2022 •

edited

Loading

mmusich commented Feb 22, 2022

tvami commented Feb 22, 2022

mmusich commented Feb 22, 2022

tvami commented Feb 22, 2022

missirol commented Feb 22, 2022

tvami commented Feb 22, 2022

cmsbuild commented Feb 22, 2022

tvami commented Feb 22, 2022

missirol commented Feb 22, 2022 •

edited

Loading

tvami commented Feb 22, 2022

missirol commented Feb 22, 2022

jfernan2 commented Feb 24, 2022

cmsbuild commented Feb 24, 2022

mmusich commented Mar 2, 2022 •

edited

Loading

jfernan2 commented Mar 2, 2022

ramankhurana commented Mar 2, 2022

makortel commented Mar 2, 2022 •

edited

Loading

Old L1T tags consumed in DQM modules #37016

Old L1T tags consumed in DQM modules #37016

Comments

tvami commented Feb 21, 2022

tvami commented Feb 21, 2022

cmsbuild commented Feb 21, 2022

cmsbuild commented Feb 21, 2022

tvami commented Feb 21, 2022

tvami commented Feb 21, 2022

tvami commented Feb 21, 2022

mmusich commented Feb 22, 2022

tvami commented Feb 22, 2022

tvami commented Feb 22, 2022

tvami commented Feb 22, 2022

cmsbuild commented Feb 22, 2022

mmusich commented Feb 22, 2022

tvami commented Feb 22, 2022

missirol commented Feb 22, 2022

tvami commented Feb 22, 2022

missirol commented Feb 22, 2022 • edited Loading

mmusich commented Feb 22, 2022

tvami commented Feb 22, 2022

mmusich commented Feb 22, 2022

tvami commented Feb 22, 2022

missirol commented Feb 22, 2022

tvami commented Feb 22, 2022

cmsbuild commented Feb 22, 2022

tvami commented Feb 22, 2022

missirol commented Feb 22, 2022 • edited Loading

tvami commented Feb 22, 2022

missirol commented Feb 22, 2022

jfernan2 commented Feb 24, 2022

cmsbuild commented Feb 24, 2022

mmusich commented Mar 2, 2022 • edited Loading

jfernan2 commented Mar 2, 2022

ramankhurana commented Mar 2, 2022

makortel commented Mar 2, 2022 • edited Loading

missirol commented Feb 22, 2022 •

edited

Loading

missirol commented Feb 22, 2022 •

edited

Loading

mmusich commented Mar 2, 2022 •

edited

Loading

makortel commented Mar 2, 2022 •

edited

Loading