-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually update Millipede to V04-11-01 #7685
Conversation
please test |
A new Pull Request was created by @iarspider for branch IB/CMSSW_12_4_X/master. @smuzaffar, @iarspider can you please review it and eventually sign? Thanks. |
millepede.spec
Outdated
@@ -1,5 +1,5 @@ | |||
### RPM external millepede V04-11-01 | |||
%define tag 9ee817fc61fe3e1b6543a8a16f7bcd8e1f8c331f | |||
%define tag 4f288098f84f274f5a241f921035af77bc07d5c8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iarspider , in this case please drop the tag
and just use %{realversion}
in the Source:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smuzaffar like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case you might want to update https://github.com/cms-sw/cmsdist/pull/7685/files#diff-19dcda17fe5f30aa2133b7a5fbb298c4471da65a7277dd395a170f1b86deb1b1R6 to match the directory. Just donwload the source , unpack it and see what directory it creates . I guess it mighty create %{n}-ii-%{realversion}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean you need to fix %setup -n %{n}-%{realversion}
statement
Pull request #7685 was updated. |
Pull request #7685 was updated. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a7293/23051/summary.html Comparison SummarySummary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
Spotted by @mmusich: #7660 (comment)