Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to read in a list of points from a .csv file (--fromfile) #937

Merged
merged 9 commits into from
Aug 19, 2024

Conversation

runtingt
Copy link
Contributor

Add an example of using --fromfile in combineTool, proposed in cms-analysis/CombineHarvester#320

@nucleosynthesis
Copy link
Contributor

I know that there is a review of the corresponding code in the CombineHarvester area but given we now have combineTool.py here, that PR should be ported over right?

@anigamova
Copy link
Collaborator

@runtingt the EnhancedCombine.py script is now included in Combine see here, do you mind moving the changes from cms-analysis/CombineHarvester#320 to HiggsAnalysis-CombinedLimit repo?

@runtingt
Copy link
Contributor Author

@anigamova Sure, I was trying to test some changes I'd made in response to @ajgilbert's comments on the harvester PR when I found the bug with the handling of infinities, I'll move these across by the end of the week.

@runtingt runtingt changed the title Document the --fromfile option from combineTool Add an option to read in a list of points from a .csv file (--fromfile) Jun 19, 2024
@runtingt
Copy link
Contributor Author

@anigamova That should be everything moved over now

@ajgilbert
Copy link
Collaborator

Just to say that this one looks fine to me now

@kcormi
Copy link
Collaborator

kcormi commented Aug 12, 2024

I've just tried to resolve the conflicts that appeared in the CI jobs, and moved the test for this specific feature to a different job than the standard counting experiment (just to make it easier to disentangle should one of them be broken).

If we are happy with that, I think its ready to merge.

@ajgilbert ajgilbert merged commit eccf7f1 into cms-analysis:main Aug 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants