Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an exception when $url is an empty string #15

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

n-peugnet
Copy link
Member

  • Throw an exception when $url is an empty string
  • Update parseFromDoc tests for empty url (abda372)

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f32b69e) 100.00% compared to head (a4cb180) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main       #15   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        33        34    +1     
===========================================
  Files              4         4           
  Lines            103       105    +2     
===========================================
+ Hits             103       105    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-peugnet n-peugnet merged commit a4cb180 into main Feb 9, 2024
10 checks passed
@n-peugnet n-peugnet deleted the empty-url branch February 9, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant