Upgrade to latest LTS node #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwwarren
commented
Oct 24, 2024
| @@ -15,7 +15,7 @@ | |||
| "all": "npm run build && npm run format && npm run lint && npm run package && npm test" | |||
| }, | |||
| "engines": { | |||
| "node": ">=16.0.0 <17.0.0", | |||
| "node": ">=18.0.0", | |||
There was a problem hiding this comment.
18 is in maintenance until April 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
===========================================
- Coverage 100.00% 95.31% -4.69%
===========================================
Files 3 3
Lines 66 64 -2
Branches 13 13
===========================================
- Hits 66 61 -5
- Misses 0 3 +3 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mattwwarren
force-pushed
the
upgrade-to-lts-node
branch
2 times, most recently
from
30ce052 to
607ac0f
Compare
also rewrite tests to be properly mocked unit tests
mattwwarren
force-pushed
the
upgrade-to-lts-node
branch
from
607ac0f to
39bfabb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #306 - I'm hoping this "signs" the prior commit so I can merge