aws-nuke update (#120)

* Update aws-nuke 2.15.0 -> 2.17.0 * Also nuke IAMInstanceProfile(,Role), MSKCluster, MSKConfiguration
cloudposse · Feb 21, 2022 · bf395ce · bf395ce
1 parent 8825f73
commit bf395ce
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 26 deletions.
diff --git a/.github/aws-nuke.yaml b/.github/aws-nuke.yaml
@@ -17,55 +17,59 @@ resource-types:
     - IAMPolicy
     - IAMGroup
     - IAMGroupPolicyAttachment
+    - IAMInstanceProfile
+    - IAMInstanceProfileRole
+    - IAMOpenIDConnectProvider
     # Deleting S3 Objects individually takes too long. We are either going to
     # delete the entire S3 bucket or nothing in it, so we skip S3Object
     # - S3Object
     - S3Bucket
     - AutoScalingGroup
+    - CloudWatchLogsLogGroup
+    - CloudformationStack
     - EC2Address
-    - ElasticBeanstalkApplication
-    - ElasticBeanstalkEnvironment
-    - EC2VPC
     - EC2DHCPOption
     - EC2Instance
-    - EC2Volume
-    - EC2Subnet
-    - EC2RouteTable
-    - EC2NATGateway
     - EC2InternetGateway
     - EC2InternetGatewayAttachment
+    - EC2KeyPair
+    - EC2NATGateway
     - EC2NetworkACL
-    - EC2SecurityGroup
     - EC2NetworkInterface
-    - EC2KeyPair
-    - ECSService
+    - EC2RouteTable
+    - EC2SecurityGroup
+    - EC2Subnet
+    - EC2VPC
+    - EC2Volume
     - ECSCluster
+    - ECSService
     - ECSTaskDefinition
     - EKSCluster
     - EKSFargateProfiles
     - EKSNodegroups
     - ELBLoadBalancer
     - ELBv2
     - ELBv2TargetGroup
-    - LambdaFunction
-    - LambdaEventSourceMapping
-    - CloudformationStack
-    - RDSInstance
-    - CloudWatchLogsLogGroup
     - EMRCluster
-    - Route53ResourceRecordSet
-    - Route53HostedZone
     - ESDomain
+    - ElasticBeanstalkApplication
+    - ElasticBeanstalkEnvironment
+    - LambdaEventSourceMapping
+    - LambdaFunction
+    - MSKCluster
+    - MSKConfiguration
+    - RDSInstance
     - RedshiftCluster
     - RedshiftParameterGroup
-    # You cannot delete automated Redshift Snapshots, and trying to delete
-    # them causes aws-nuke to exit with failure. Since we are not taking
-    # manual snapshots, we do not need to worry about them, but if we did,
-    # we should create a filter that leaves the automated snapshots alone.
-    # - RedshiftSnapshot
+  # You cannot delete automated Redshift Snapshots, and trying to delete
+  # them causes aws-nuke to exit with failure. Since we are not taking
+  # manual snapshots, we do not need to worry about them, but if we did,
+  # we should create a filter that leaves the automated snapshots alone.
+  # - RedshiftSnapshot
+    - Route53HostedZone
+    - Route53ResourceRecordSet
     - RedshiftSubnetGroup
-    - IAMOpenIDConnectProvider
-
+
   # don't nuke IAM users
   excludes:
     - IAMUser
@@ -248,6 +252,12 @@ presets:
         - property: "tag:Name"
           type: "regex"
           value: "^cpco-.*"
+      IAMInstanceProfile:
+        - type: "regex"
+          value: "^cpco-.*"
+      IAMInstanceProfileRole:
+        - type: "regex"
+          value: "^cpco-.*"
       IAMRole:
         - type: "regex"
           value: "^cpco-.*"

diff --git a/.github/workflows/aws-nuke.yml b/.github/workflows/aws-nuke.yml
@@ -27,7 +27,7 @@ jobs:
       - name: checkout
         uses: actions/checkout@v2
       - name: aws-nuke
-        uses: "docker://quay.io/rebuy/aws-nuke:v2.15.0"
+        uses: "docker://quay.io/rebuy/aws-nuke:v2.17.0"
         with:
           args: "--config .github/aws-nuke.yaml --force"
         env:
@@ -43,7 +43,7 @@ jobs:
       - name: checkout
         uses: actions/checkout@v2
       - name: aws-nuke
-        uses: "docker://quay.io/rebuy/aws-nuke:v2.15.0"
+        uses: "docker://quay.io/rebuy/aws-nuke:v2.17.0"
         with:
           args: "--config .github/aws-nuke.yaml --force --no-dry-run"
         env: