Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ssh_key_pair generation when an existing keypair is being passed in #32

Closed
wants to merge 5 commits into from

Conversation

BGarber42
Copy link

what

  • If you're passing in a keypair name, don't generate one, and done try to load a local file that doesn't exist

why

  • You want to use an existing keypair
  • You don't want plan to fail.

references

Disable embedded keypair if we're passing one in.
@BGarber42 BGarber42 requested review from a team as code owners August 5, 2021 07:19
@BGarber42 BGarber42 requested a review from a team as a code owner August 5, 2021 07:20
@BGarber42 BGarber42 requested review from srhopkins and brcnblc and removed request for a team August 5, 2021 07:20
@nitrocode
Copy link
Member

nitrocode commented Aug 5, 2021

Thank you for your contribution.

In our bastion component, we use an additional ssh key enabled toggle and pass that in to explicitly enable and disable the module itself.

This method also works. Please see comments.

@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode added the do not merge Do not merge this PR, doing so would cause problems label Oct 21, 2021
@mergify
Copy link

mergify bot commented Oct 21, 2021

This pull request is now in conflict. Could you fix it @BGarber42? 🙏

@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode added the patch A minor, backward compatible change label Oct 21, 2021
@hans-d hans-d added the stale This PR has gone stale label Mar 2, 2024
@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

@hans-d hans-d closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge this PR, doing so would cause problems patch A minor, backward compatible change stale This PR has gone stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants