Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NSC): add IPVS service timeouts #1590

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Conversation

aauren
Copy link
Collaborator

@aauren aauren commented Dec 21, 2023

This is a feature that has been requested a few times over the years and would bring us closer to feature parity with other k8s network implementations for service proxy.

Adds the options:

      --service-tcp-timeout duration                  Specify TCP timeout for IPVS services in standard duration syntax (e.g. '5s', '1m'), default 0s preserves default system value (default: 0s)
      --service-tcpfin-timeout duration               Specify TCP FIN timeout for IPVS services in standard duration syntax (e.g. '5s', '1m'), default 0s preserves default system value (default: 0s)
      --service-udp-timeout duration                  Specify UDP timeout for IPVS services in standard duration syntax (e.g. '5s', '1m'), default 0s preserves default system value (default: 0s)

Keeps backwards compatibility by default defining them as 0s which will keep the IPVS defaults in place (which is how these are currently set). The IPVS default appear to be the same on most systems, which should be:

TCP Timeout: 15 minutes
TCPFIN Timeout: 2 minutes
UDP Timeout: 5 minutes

Fixes #911 #521 - Without relying on the application to send keep-alives

Potentially resolves #1577 - But there isn't enough information in the ticket in order to know for sure.

This is a feature that has been requested a few times over the years and
would bring us closer to feature parity with other k8s network
implementations for service proxy.
@aauren aauren merged commit ced5102 into master Dec 26, 2023
7 checks passed
@aauren aauren deleted the add_ipvs_timeouts_config branch December 26, 2023 20:26
@aauren
Copy link
Collaborator Author

aauren commented Jan 6, 2024

Progress towards: #1596

@aauren aauren added this to the v2.1.0 milestone Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting RST on long-lived connections TCP connection reset after some hours of idle
1 participant