feat(NSC): add IPVS service timeouts #1590
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature that has been requested a few times over the years and would bring us closer to feature parity with other k8s network implementations for service proxy.
Adds the options:
Keeps backwards compatibility by default defining them as
0s
which will keep the IPVS defaults in place (which is how these are currently set). The IPVS default appear to be the same on most systems, which should be:Fixes #911 #521 - Without relying on the application to send keep-alives
Potentially resolves #1577 - But there isn't enough information in the ticket in order to know for sure.