Merge pull request #210 from cloudinary/fix-plugins

fix: return last plugin response
cloudinary · Mar 20, 2023 · f1ee369 · f1ee369
2 parents b180bff + 1f725b8
commit f1ee369
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/packages/html/src/utils/render.ts b/packages/html/src/utils/render.ts
@@ -1,4 +1,4 @@
-import {Plugins, HtmlPluginState, BaseAnalyticsOptions} from '../types'
+import {Plugins, HtmlPluginState, BaseAnalyticsOptions, PluginResponse} from '../types'
 import {CloudinaryVideo, CloudinaryImage} from "@cloudinary/url-gen";
 
 /**
@@ -11,13 +11,15 @@ import {CloudinaryVideo, CloudinaryImage} from "@cloudinary/url-gen";
  * @param analyticsOptions {BaseAnalyticsOptions} analytics options for the url to be created
  */
 export async function render(element: HTMLImageElement | HTMLVideoElement, pluginCloudinaryAsset: CloudinaryImage | CloudinaryVideo, plugins: Plugins, pluginState: HtmlPluginState, analyticsOptions?: BaseAnalyticsOptions) {
-    if(plugins === undefined) return;
-    for(let i = 0; i < plugins.length; i++){
-        const response = await plugins[i](element, pluginCloudinaryAsset, pluginState, analyticsOptions);
-        if(response === 'canceled'){
+    if (plugins === undefined) return;
+    let response: PluginResponse;
+    for (let i = 0; i < plugins.length; i++) {
+        response = await plugins[i](element, pluginCloudinaryAsset, pluginState, analyticsOptions);
+        if (response === 'canceled') {
             break;
-        } else {
-            return response
         }
     }
+    if (response !== 'canceled') {
+        return response;
+    }
 }