tokio-quiche: add support for sending additional headers #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghedo
force-pushed
the
tq-additional-headers
branch
3 times, most recently
from
153ae65 to
8043a7b
Compare
LPardue
reviewed
Feb 25, 2025
LPardue
previously approved these changes
Feb 25, 2025
evanrittenhouse
previously approved these changes
Feb 25, 2025
ghedo
force-pushed
the
tq-additional-headers
branch
from
8043a7b to
d610a8f
Compare
Since quiche will reject multiple calls to `send_response*()` on the same stream, we need to call `send_additional_headers()` after the initial headers are sent.
ghedo
force-pushed
the
tq-additional-headers
branch
from
d610a8f to
6f73e78
Compare
LPardue
approved these changes
Feb 25, 2025
evanrittenhouse
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since quiche will reject multiple calls to
send_response*()on the same stream, we need to callsend_additional_headers()after the initial headers are sent.