Upgrade bincode to released version 2 and fix compilation when disabled #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the build of
plexi-core
fails when thebincode
feature is disabled:This is because the bincode arm is compiled out if the feature is disabled. Instead, keep the match arm and change it to a runtime error if bincode is not enabled.
Bincode 2 has also been released, so we can upgrade to it. There is a small difference in how the
Decode
andBorrowDecode
traits are defined which we must adapt to.