fix:update azurerm version #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13archit
reviewed
Sep 18, 2024
13archit
reviewed
Sep 18, 2024
13archit
reviewed
Sep 18, 2024
13archit
reviewed
Sep 18, 2024
13archit
reviewed
Sep 18, 2024
13archit
reviewed
Sep 18, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
|
|
1 similar comment
|
|
|
|
13archit
reviewed
Oct 16, 2024
examples/complete/main.tf
Outdated
| locals { | ||
| name = "app" | ||
| environment = "test" | ||
| name = "lacoster-23" |
There was a problem hiding this comment.
Please revert it to app and test
13archit
reviewed
Oct 16, 2024
examples/complete/main.tf
Outdated
| azurerm.main_sub = azurerm | ||
| } | ||
|
|
||
| name = "oliveware-23" |
There was a problem hiding this comment.
Please use local here in name and environment.
|
d4kverma
reviewed
Oct 28, 2024
| ## Flexible Mysql server module call. | ||
| ##----------------------------------------------------------------------------- | ||
| module "flexible-mysql" { | ||
| depends_on = [module.resource_group, module.vnet, data.azurerm_resource_group.main] | ||
| source = "clouddrove/flexible-mysql/azure" |
d4kverma
reviewed
Oct 28, 2024
| @@ -92,7 +92,6 @@ module "flexible-mysql" { | |||
| virtual_network_id = module.vnet.vnet_id[0] | |||
| delegated_subnet_id = module.subnet.default_subnet_id[0] | |||
| mysql_version = "8.0.21" | |||
| mysql_server_name = "testmysqlserver" | |||
There was a problem hiding this comment.
any specific reason to remove it
There was a problem hiding this comment.
tflint gave error that this variable is not being use other examples.
that's why I removed this variable and we can give the name of it from labels.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
subscription_idfor provider in root modulewhy