v0.8.3: PyMongo 4+ #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkassemi
force-pushed
the
jk-pymongo-upgrade
branch
2 times, most recently
from
4902beb to
abad703
Compare
jkassemi
changed the title
jkassemi
force-pushed
the
jk-pymongo-upgrade
branch
3 times, most recently
from
a9026fe to
e284090
Compare
jkassemi
changed the title
jkassemi
force-pushed
the
jk-pymongo-upgrade
branch
2 times, most recently
from
c6d3b6e to
d3cd0f3
Compare
jkassemi
changed the title
jkassemi
force-pushed
the
jk-pymongo-upgrade
branch
from
d3cd0f3 to
918331c
Compare
jkassemi
force-pushed
the
jk-pymongo-upgrade
branch
3 times, most recently
from
a47fad2 to
3bbbf29
Compare
jkassemi
force-pushed
the
jk-pymongo-upgrade
branch
from
3bbbf29 to
9af116a
Compare
Ports fixes from upstream to account for the simpler changes in the migration guide (https://pymongo.readthedocs.io/en/stable/migrate-to-pymongo4.html): * mongodb_support from upstream me * pymongo_support from upstream me * deprecate collection_names in favour of list_collection_names * uuid representation defaults to pythonLegacy * deprecate MongoReplicaSetClient * use profile command instead of Database.set_profiling_level * use count_documents instead of cursor.count * use find_one_and_update instead of find_and_modify * use command instead of createUser and query * use update_one instead of collection.update
Evaluated coverage and porting tests from upstream where we lacked coverage.
* Simple repo link fix * Updated benchmarks
jkassemi
force-pushed
the
jk-pymongo-upgrade
branch
from
9af116a to
1331348
Compare
|
Before working on any upgrades, we need to make sure that the current setup is up-to-date and that the test suite is passing. Only then we we will truly know what needed fixing because of the upgraded PyMongo and what needed fixing because this package was poorly maintained to begin with. Let's ship these PRs first and then work on this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports from upstream mongoengine and minor independent changes to support pymongo 4.
We worked through the migration guide to determine potential issues. Where possible we ported the solution adopted by the upstream mongoengine project. Maintains backwards compatibility.
We now require
pymongo>=3.13.Additionally:
hint,limit,skip, andbatch_sizepersistence on cursors that would impact services during upgradeMy sincere apologies for the size of this commit; there wasn't a clear candidate for release until this point. Commits are structured to provide a sense of order to this work.