Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(/customization/user-button) Add Vue examples; update copy #1999

Merged
merged 2 commits into from
Feb 7, 2025
Merged

(/customization/user-button) Add Vue examples; update copy #1999

merged 2 commits into from
Feb 7, 2025

Conversation

wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Feb 6, 2025 •
edited
Loading

🔎 Previews:

What does this solve?

  • Since the implementation uses Vue slots (rather than props like in React) to pass in custom components, it's important to document this approach.

What changed?

  • Adds Vue examples to each section of the custom menu items docs
  • Shows proper usage of template slots for custom components

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

Hey, here’s your docs preview: https://clerk.com/docs/pr/1999

@wobsoriano wobsoriano changed the title Add Vue SDK custom actions and links examples Add Vue SDK custom menu items examples Feb 6, 2025
@wobsoriano wobsoriano changed the title Add Vue SDK custom menu items examples Add Vue SDK custom <UserButton /> menu items examples Feb 7, 2025
@wobsoriano wobsoriano marked this pull request as ready for review February 7, 2025 16:18
@wobsoriano wobsoriano requested a review from a team as a code owner February 7, 2025 16:18
@alexisintech alexisintech changed the title Add Vue SDK custom <UserButton /> menu items examples (/customization/user-button) Add Vue examples; update copy Feb 7, 2025
alexisintech
alexisintech approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, I've updated the copy on this page as it was much needed, and thus, updated the PR title.
all examples seem to be working for me locally.
thanks so much for being on top of this! would you say that these examples would pretty much be the same for nuxt?

(I've approved, feel free to merge when you're ready)

@wobsoriano
Copy link
Member Author

wobsoriano commented Feb 7, 2025 •
edited
Loading

awesome, I've updated the copy on this page as it was much needed, and thus, updated the PR title. all examples seem to be working for me locally. thanks so much for being on top of this! would you say that these examples would pretty much be the same for nuxt?

(I've approved, feel free to merge when you're ready)

Yes same for Nuxt! Appreciate your quick review on this one <3

@wobsoriano wobsoriano merged commit 03b31d0 into main Feb 7, 2025
6 checks passed
@wobsoriano wobsoriano deleted the rob/eco-361-document-how-to-use-custom-pages-and-menu-items-in-vue-sdk branch February 7, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexisintech alexisintech alexisintech approved these changes

Assignees
No one assigned
Labels
deploy-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wobsoriano @alexisintech