Skip to content

Commit

Permalink
Fix typos and bender tags order in the manual tests
Browse files Browse the repository at this point in the history
  • Loading branch information
KarolDawidziuk committed Feb 8, 2023
1 parent 1603f5f commit 7b2211c
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions plugins/easyimage/plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -350,8 +350,8 @@
sizes: '100vw'
} );

// Ensure that replacing placeholder image with the final one
// ss considered a change of content (#5414).
// Ensure that replacing the placeholder image with the final one
// is considered a content change (#5414).
this.editor.fire( 'change' );
} );

Expand Down
4 changes: 2 additions & 2 deletions plugins/uploadwidget/plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,8 @@
editor.getSelection().selectBookmarks( bookmarks );
}

// Ensure that replacing upload placeholder with the final
// uploaded element is considered a change of content (#5414).
// Ensure that replacing the upload placeholder with the final
// uploaded element is considered a content change (#5414).
editor.fire( 'change' );
},

Expand Down
2 changes: 1 addition & 1 deletion tests/plugins/easyimage/manual/changeevent.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@bender-tags: 4.20.2, 5414, bug
@bender-tags: 4.20.2, bug, 5414
@bender-ui: collapsed
@bender-ckeditor-plugins: wysiwygarea, toolbar, easyimage, undo
@bender-include: ../_helpers/tools.js
Expand Down
2 changes: 1 addition & 1 deletion tests/plugins/easyimage/uploadintegrations.js
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@
wait();
},

// #5414
// (#5414)
'test change event is fired after the upload finishes': function() {
var editor = this.editor,
listeners = this.listeners;
Expand Down
2 changes: 1 addition & 1 deletion tests/plugins/uploadfile/manual/changeevent.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@bender-tags: 4.20.2, 5414, bug
@bender-tags: 4.20.2, bug, 5414
@bender-ui: collapsed
@bender-ckeditor-plugins: wysiwygarea, toolbar, uploadfile, undo
@bender-include: ../../uploadwidget/manual/_helpers/xhr.js
Expand Down
2 changes: 1 addition & 1 deletion tests/plugins/uploadfile/uploadfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ bender.test( {
assert.areSame( 'abort', loader.status, 'Loader status' );
},

// #5414
// (#5414)
'test firing change event after the upload finishes': function() {
var editor = this.editors.uploadfile,
uploads = editor.uploadRepository,
Expand Down
2 changes: 1 addition & 1 deletion tests/plugins/uploadimage/manual/changeevent.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@bender-tags: 4.20.2, 5414, bug
@bender-tags: 4.20.2, bug, 5414
@bender-ui: collapsed
@bender-ckeditor-plugins: wysiwygarea, toolbar, uploadimage, undo
@bender-include: ../../uploadwidget/manual/_helpers/xhr.js
Expand Down
2 changes: 1 addition & 1 deletion tests/plugins/uploadimage/uploadimage.js
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@
} );
},

// #5414
// (#5414)
'test change event is fired after upload finishes': function() {
bender.editorBot.create( {
name: 'undo-integration-change-after-upload',
Expand Down
2 changes: 1 addition & 1 deletion tests/plugins/uploadwidget/uploadwidget.js
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,7 @@
} );
},

// #5414
// (#5414)
'test firing change after calling replaceWith() method': function() {
var bot = this.editorBot,
editor = bot.editor,
Expand Down

0 comments on commit 7b2211c

Please sign in to comment.