Add pickle support to ActionShortcut #219
Open
+37
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my setup (Mac), multiprocessing defaults to pickling + unpickling state from the main process to worker processes. Pickling doesn't/can't support local functions. Because ActionShortcut's getattr returns a local function regardless of the attribute name that's requested, instances of that class cannot be pickled without this fix.
The solution is to implement a custom getstate and setstate, to state how ActionShortcut should be pickled/unpickled.
Includes a basic test.
https://docs.python.org/3/library/pickle.html#object.__getstate__
https://docs.python.org/3/library/multiprocessing.html