MoveNoteProcessor in its own thread
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariard
force-pushed
the
2023-07-impr-note-processor
branch
from
f8dfa40 to
bdde676
Compare
|
Rebased at |
ariard
force-pushed
the
2023-07-impr-note-processor
branch
from
bdde676 to
a9553fb
Compare
|
Updated at |
ariard
force-pushed
the
2023-07-impr-note-processor
branch
2 times, most recently
from
037ebd0 to
dd1d990
Compare
|
Updated at dd1d990 The DB is functional and is saved on-disk. List of events received from the sample can be tested with |
ariard
force-pushed
the
2023-07-impr-note-processor
branch
from
dd1d990 to
732cead
Compare
ariard
force-pushed
the
2023-07-impr-note-processor
branch
from
732cead to
7b4cbf7
Compare
|
Updated at 7b4cbf7 with CI fixed normally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of the SQLite support #24, this PR moves
NoteProcessorout ofServiceManagerand aims to be the module receiving the DB write/read request from the other components (client handler, gateway, RPC client).NoteProcessoris a good module candidate to support NIP33 queries (see #22) as event will have to be pruned out of the database, if they’re replaced.