Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 72: Generalize MeterValue #352

Open
wants to merge 1 commit into
base: feature/init-generalize
Choose a base branch
from
Open

Issue 72: Generalize MeterValue #352

wants to merge 1 commit into from

Conversation

lydiazcheng
Copy link
Contributor

⚠️ This branch is based on feature/init-generalize: #346

Changes

  1. Generalize MeterValue entity
  2. Create MeterValue mappers for ocpp 2.0.1

Regression Test

  1. Start a transaction.
Screenshot 2025-02-07 at 6 08 28 PM
  1. Update the transaction
Screenshot 2025-02-07 at 6 08 45 PM Screenshot 2025-02-07 at 6 09 18 PM
  1. End the transaction and get final cost.
Screenshot 2025-02-07 at 6 09 38 PM Screenshot 2025-02-07 at 6 09 54 PM
  1. The transaction is stored in db with correct final cost.
Screenshot 2025-02-07 at 6 10 48 PM

@lydiazcheng
Issue 72: Generalize MeterValue
ad726b2 
Signed-off-by: Zihe Cheng <lydiazcheng@users.noreply.github.com>
@lydiazcheng lydiazcheng self-assigned this Feb 7, 2025
@lydiazcheng lydiazcheng mentioned this pull request Feb 7, 2025
Closed
@lydiazcheng lydiazcheng linked an issue Feb 7, 2025 that may be closed by this pull request
[OCPP 1.6] Generalize database entities for MeterValues citrineos/citrineos#72
Open
@lydiazcheng lydiazcheng mentioned this pull request Feb 10, 2025
Open
langiole
langiole reviewed Feb 10, 2025
View reviewed changes
01_Data/src/layers/sequelize/mapper/2.0.1/MeterValueMapper.ts
import { MeterValue } from '../../model/TransactionEvent';

export class MeterValueMapper {
static toMeterValueType(meterValue: MeterValue): OCPP2_0_1.MeterValueType {
Copy link
Contributor

@langiole langiole Feb 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we're missing the mapping of customObject field?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langiole langiole langiole left review comments

Assignees

@lydiazcheng lydiazcheng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OCPP 1.6] Generalize database entities for MeterValues
2 participants
@lydiazcheng @langiole