Issue 86: Restructure APIs and Implement RemoteStopTransaction #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zihe Cheng <lydiazcheng@users.noreply.github.com>
Signed-off-by: Zihe Cheng <lydiazcheng@users.noreply.github.com>
Signed-off-by: Zihe Cheng <lydiazcheng@users.noreply.github.com>
lydiazcheng
changed the title
lydiazcheng
requested review from
ChrisWeissmann,
deye9,
langiole,
yuvenus,
elliot-sabitov,
thanaParis and
eddygrebt
Signed-off-by: Zihe Cheng <lydiazcheng@users.noreply.github.com>
Signed-off-by: Zihe Cheng <lydiazcheng@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Implement RemoteStopTransaction endpoint and ensure Citrine to support apis of 2 OCPP versions.
Changes
AbstractModuleApi:SystemConfigendpoints only for data apis./ocpp/1.6/evdriver/remoteStopTransactionapi.tsinEVDrivermodule into 3 api files for ocpp 2.0.1 message, ocpp 1.6 message and data endpoints respectivelyTests
Case 1: Call OCPP 1.6 endpoint
Case 2: Call OCPP 2.0.1 endpoint
Case 3: The endpoint ocpp version doesn't match the connection protocol version
Charge connects to Citrine with protocol 2.0.1 but send a 1.6 call
