Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 74: Generalize IdTokenInfo (No.8) #337

Closed
wants to merge 1 commit into from
Closed

Issue 74: Generalize IdTokenInfo (No.8) #337

wants to merge 1 commit into from

Conversation

lydiazcheng
Copy link
Contributor

⚠️ This branch is based on another feature branch. Please take care of the merge order or update the destination branch before merging.

This PR is to generalize the IdTokenInfo entity.

Changes

  1. Generalize the IdTokenInfo db entity.
  2. Generate mappers for OCPP 2.0.1 IdTokenInfo and OCPP 1.6 IdTagInfo
  3. Use fromModel() in modules.

@lydiazcheng
Issue 74: Generalize IdTokenInfo
8b36a72 
Signed-off-by: Zihe Cheng <lydiazcheng@users.noreply.github.com>
@lydiazcheng lydiazcheng self-assigned this Jan 28, 2025
@lydiazcheng lydiazcheng linked an issue Jan 28, 2025 that may be closed by this pull request
[OCPP 1.6] Generalize database entities for IdTokenInfo citrineos/citrineos#74
Open
@lydiazcheng lydiazcheng marked this pull request as draft February 10, 2025 15:54
@lydiazcheng
Copy link
Contributor Author

Pls see the new PR: #353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisWeissmann ChrisWeissmann Awaiting requested review from ChrisWeissmann

@elliot-sabitov elliot-sabitov Awaiting requested review from elliot-sabitov

@thanaParis thanaParis Awaiting requested review from thanaParis

@eddygrebt eddygrebt Awaiting requested review from eddygrebt

Assignees

@lydiazcheng lydiazcheng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OCPP 1.6] Generalize database entities for IdTokenInfo
1 participant
@lydiazcheng