Header: Fix issues with search toggle in header #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a small github actions issue at the moment so this will probably fail right now: https://www.githubstatus.com/incidents/6r4sms3hcj3x |
davidrapson
force-pushed
the
header-a11y-fixes
branch
from
c0cd9a7 to
c4dc0d3
Compare
davidrapson
requested review from
davidsauntson and
marianayovcheva
as code owners
davidrapson
force-pushed
the
header-a11y-fixes
branch
3 times, most recently
from
70096ee to
bc530e9
Compare
davidsauntson
approved these changes
Jun 22, 2022
1. Was using title rather than aria-label for the description 2. Was missing a type attribute on the button element 3. Was missing aria-controls to associate the button with the search 4. Both the toggle and the search form were using icon fonts which causes additional text to be read out when interacting with either element. Switch to use SVG icons
davidrapson
force-pushed
the
header-a11y-fixes
branch
from
bc530e9 to
ee00dae
Compare
|
Just added a changelog entry too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by #2099 this PR attempts to fix a few accesibility and markup quality issues with the header search toggle: