Update on amundsen_vocabulary.json #114
Conversation
tratsimbazafy
commented
Sep 25, 2024
tratsimbazafy
commented
- Added sdn_parameter_urn in the attribute of the variable Trans (source: https://vocab.nerc.ac.uk/collection/P01/current/POPTDR01/ )
- suggested a new name for the variable Trans to be consistent
- Added sdn_parameter_urn in the attribute of the variable Trans (source: https://vocab.nerc.ac.uk/collection/P01/current/POPTDR01/ ) - suggested a new name for the variable Trans to be consistent
|
Thanks @tratsimbazafy for the PR, maybe we can wait to merge this and include all the extra vocabulary to this PR? |
|
Yes, we can wait! That PR was meant to be a kind of demo for us. Another should follow.
By the way, could you please add Pascal ( @guillotp ) as reviewer especially for this particular json file as he is the one that produces the processed data using this vocabulary ? That way, when he will be boarding the ship, he can follow all the addings I make.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Jessy Barrette ***@***.***>
Sent: Thursday, September 26, 2024 8:55:52 AM
To: cioos-siooc/ocean-data-parser ***@***.***>
Cc: Tahiana Ratsimbazafy ***@***.***>; Mention ***@***.***>
Subject: Re: [cioos-siooc/ocean-data-parser] Update on amundsen_vocabulary.json (PR #114)
Thanks @tratsimbazafy<https://github.com/tratsimbazafy> for the PR, maybe we can wait to merge this and include all the extra vocabulary to this PR?
—
Reply to this email directly, view it on GitHub<#114 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFBY5VSDCKURFM2L7O42FQLZYP75RAVCNFSM6AAAAABO3GHSUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZWHA3TMMJUHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Certainement! |
Added attributes from NERC Vocabulary Server.
|
@TahianaRatsimbazafy you can populate for now maybe just the |
|
@JessyBarrette , sounds good!! |
|
sounds good to me! |
- added more sdn_parameter_urn and sdn_uom_urn as possible. - added sdn_instrument_urn to indicate the instrument used to record the data. - The variable GPS was removed as it is not a real measured variable. - Looking at the variable name "Dens" and "D_ct", there is an ambiguity regarding their "standard_name" they are sharing. It would be better if Pascal have a look at them to insure the use of the most appropriate information.
|
@TahianaRatsimbazafy @guillotp Les tests que je viens d'ajouter ont détecté (voir ici que certaines variables ont toujours un sdn_parameter_urn qui pointe vers 46 SDN:P07::CFSN0445 |
|
@JessyBarrette SDN:P07::CFSN0023 Je me demande pourquoi celles-ci n'étaient pas détecter par le test ? |
|
hum bonne question... |
|
@tratsimbazafy C'est parce qu'il ya une erreur dans l'attribut example: |
|
je vais pousser tous les enlever et laisser une valeur vide "" et pousser cette version. |
|
je viens de voir qu'il y avais les même typo aussi dans plusieurs autres. Ex: dans la latitude (sdn_paramater_urn) |
|
Le dictionnaire AS QO a été mis à jour seulement pour toutes les variables qui concernent la rosette. Il faut qu'on fasse le même travail pour les autres instruments. |
Corrigé le typo "sdn_paramater_urn" partout pour "sdn_parameter_urn".
|
Toujours deux autres termes qui ne sont pas correct
C'est correct pas de problème. Est-ce que vous voulez rajouter quelque chose qui dit si un terme est spécifique à instrument? Je sais qu'on en avait discuté déjà. |
|
il y a un terme |
|
On ne peut pas mettre une version juste avec les variables rosette ? |
