-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ODF Time Variable Timezone? #93
Comments
Assume it is UTC. |
@guillotp always? |
For QO and Amundsen Science: yes. |
MLI is also always using UTC. |
You mean leaving UTC within the units. I think it's alright, it is still compliant with the CF standards where if no time zone is provided it defaults to UTC. See note https://cfconventions.org/Data/cf-conventions/cf-conventions-1.8/cf-conventions.html#time-coordinate |
I did not know. Thank you. |
Issue
odf_parser for the moment does not handle any timezone information. So far, the only timezone information observed within the ODF files is sometimes available within the UNITS of the ODF SYTM variables.
All the test ODFs (~2500 files) also used the standard time format:
dd-MMM-yyyy HH:mm:ss
(ex:31-DEC-2019 23:50:00.00
) with no timezone information attached. This format is used within the data and the header.The only timezone retrieved so far are:
As of now
We're not handling any timezone and just output a warning if the time variable has a unit different than the ones listed above.
We could potentially replace the warning by an error to be more conservative.
Solution?
What should be done in the future? Is it an actual issue?
What to assume:
The text was updated successfully, but these errors were encountered: