Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored RealVectorInitializer based on RefactorFirst analysis #770

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

cicirello
Copy link
Owner

Summary

Refactored RealVectorInitializer based on RefactorFirst analysis, which identified it as a god class.

Closing Issues

Closes #768

Types of changes

  • I have read the CONTRIBUTING document.
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvements to existing code, such as refactoring or optimizations (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cicirello cicirello self-assigned this Dec 12, 2024
Copy link
Contributor

JaCoCo Test Coverage Summary Statistics

  • Coverage: 100%
  • Branches: 100%

@cicirello cicirello merged commit a7f2312 into master Dec 12, 2024
5 checks passed
@cicirello cicirello deleted the refactor-first branch December 12, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

RefactorFirst identifies RealVectorInitializer as a god class
1 participant