Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): Preserve input type within for strategy #207

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

rbenyoussef
Copy link
Contributor

Issue Number

fixes #

Describe the changes you've made

Describe if there is any unusual behaviour of your code

Additional context

Test plan

Checklist

  • Refer to issue(s) the PR solves
  • New java code is covered by tests
  • Add screenshots or gifs of the new behavior, if applicable.
  • All new and existing tests pass
  • No git conflict

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.93%. Comparing base (2d0fffb) to head (875987f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #207      +/-   ##
============================================
- Coverage     61.44%   60.93%   -0.51%     
- Complexity     3343     3345       +2     
============================================
  Files           662      662              
  Lines         17790    18195     +405     
  Branches       1000     1001       +1     
============================================
+ Hits          10931    11088     +157     
- Misses         6459     6707     +248     
  Partials        400      400              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boddissattva boddissattva merged commit 1043a71 into main Oct 29, 2024
3 checks passed
@boddissattva boddissattva deleted the fix/preserve_input_type_for_strategy branch October 29, 2024 08:58
@KarimGl KarimGl added the bug Something isn't working label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants