fix(server): remove write numbers as strings in reports (#11)

Co-authored-by: Redouane BENYOUSSEF <redouane.benyoussef@gmail.com>
chutney-testing · Feb 27, 2024 · ecb73a5 · ecb73a5
1 parent 4f2701c
commit ecb73a5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/chutney/server/src/main/java/com/chutneytesting/ServerConfiguration.java b/chutney/server/src/main/java/com/chutneytesting/ServerConfiguration.java
@@ -254,7 +254,6 @@ public ObjectMapper reportObjectMapper() {
             .setSerializationInclusion(JsonInclude.Include.NON_NULL)
             .disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS)
             .disable(SerializationFeature.FAIL_ON_EMPTY_BEANS)
-            .enable(JsonWriteFeature.WRITE_NUMBERS_AS_STRINGS.mappedFeature())
             .registerModule(jdomElementModule)
             .findAndRegisterModules();
     }

diff --git a/.../server/src/main/java/com/chutneytesting/execution/api/ScenarioExecutionUiController.java b/.../server/src/main/java/com/chutneytesting/execution/api/ScenarioExecutionUiController.java
@@ -35,7 +35,6 @@
 import com.chutneytesting.tools.ui.MyMixInForIgnoreType;
 import com.fasterxml.jackson.annotation.JsonInclude;
 import com.fasterxml.jackson.core.JsonGenerator;
-import com.fasterxml.jackson.core.json.JsonWriteFeature;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.SerializationFeature;
 import com.fasterxml.jackson.databind.SerializerProvider;
@@ -210,7 +209,6 @@ public ObjectMapper dtoReportObjectMapper() {
             .setSerializationInclusion(JsonInclude.Include.NON_NULL)
             .disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS)
             .disable(SerializationFeature.FAIL_ON_EMPTY_BEANS)
-            .enable(JsonWriteFeature.WRITE_NUMBERS_AS_STRINGS.mappedFeature())
             .registerModule(jdomElementModule)
             .findAndRegisterModules();
     }

diff --git a/chutney/server/src/test/resources/blackbox/actions/sql.feature b/chutney/server/src/test/resources/blackbox/actions/sql.feature
@@ -81,22 +81,22 @@ Feature: SQL Task test
         And the report contains record results
             Do compare
                 With actual ${#json(#report, "$.report.steps[-1:].stepOutputs.recordResult").toString()}
-                With expected [[{"affectedRows":"-1","headers":["ID","NAME","EMAIL"],"rows":[["1","laitue","laitue@fake.com"],["2","carotte","kakarot@fake.db"]],"columns":[{"name":"ID","index":"0"},{"name":"NAME","index":"1"},{"name":"EMAIL","index":"2"}],"records":[{"cells":[{"column":{"name":"ID","index":"0"},"value":"1"},{"column":{"name":"NAME","index":"1"},"value":"laitue"},{"column":{"name":"EMAIL","index":"2"},"value":"laitue@fake.com"}]},{"cells":[{"column":{"name":"ID","index":"0"},"value":"2"},{"column":{"name":"NAME","index":"1"},"value":"carotte"},{"column":{"name":"EMAIL","index":"2"},"value":"kakarot@fake.db"}]}]}]]
+                With expected [[{"affectedRows":-1,"headers":["ID","NAME","EMAIL"],"rows":[[1,"laitue","laitue@fake.com"],[2,"carotte","kakarot@fake.db"]],"columns":[{"name":"ID","index":0},{"name":"NAME","index":1},{"name":"EMAIL","index":2}],"records":[{"cells":[{"column":{"name":"ID","index":0},"value":1},{"column":{"name":"NAME","index":1},"value":"laitue"},{"column":{"name":"EMAIL","index":2},"value":"laitue@fake.com"}]},{"cells":[{"column":{"name":"ID","index":0},"value":2},{"column":{"name":"NAME","index":1},"value":"carotte"},{"column":{"name":"EMAIL","index":2},"value":"kakarot@fake.db"}]}]}]]
                 With mode equals
         And the report contains firstRow output
             Do compare
                 With actual ${#json(#report, "$.report.steps[-1:].stepOutputs.firstRow").toString()}
-                With expected [{"cells":[{"column":{"name":"ID","index":"0"},"value":"1"},{"column":{"name":"NAME","index":"1"},"value":"laitue"},{"column":{"name":"EMAIL","index":"2"},"value":"laitue@fake.com"}]}]
+                With expected [{"cells":[{"column":{"name":"ID","index":0},"value":1},{"column":{"name":"NAME","index":1},"value":"laitue"},{"column":{"name":"EMAIL","index":2},"value":"laitue@fake.com"}]}]
                 With mode equals
         And the report contains rows output
             Do compare
                 With actual ${#json(#report, "$.report.steps[-1:].stepOutputs.rows").toString()}
-                With expected [{"rows":[{"cells":[{"column":{"name":"ID","index":"0"},"value":"1"},{"column":{"name":"NAME","index":"1"},"value":"laitue"},{"column":{"name":"EMAIL","index":"2"},"value":"laitue@fake.com"}]},{"cells":[{"column":{"name":"ID","index":"0"},"value":"2"},{"column":{"name":"NAME","index":"1"},"value":"carotte"},{"column":{"name":"EMAIL","index":"2"},"value":"kakarot@fake.db"}]}]}]
+                With expected [{"rows":[{"cells":[{"column":{"name":"ID","index":0},"value":1},{"column":{"name":"NAME","index":1},"value":"laitue"},{"column":{"name":"EMAIL","index":2},"value":"laitue@fake.com"}]},{"cells":[{"column":{"name":"ID","index":0},"value":2},{"column":{"name":"NAME","index":1},"value":"carotte"},{"column":{"name":"EMAIL","index":2},"value":"kakarot@fake.db"}]}]}]
                 With mode equals
         And the report contains affectedRows output
             Do compare
                 With actual ${#json(#report, "$.report.steps[-1:].stepOutputs.affectedRows").toString()}
-                With expected ["-1"]
+                With expected [-1]
                 With mode equals
 
     Scenario: Sql query wrong table