feat(api): add <p> and <a> and <br> elements
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5 +/- ##
==========================================
- Coverage 84.07% 83.13% -0.95%
==========================================
Files 10 10
Lines 2261 2324 +63
Branches 107 119 +12
==========================================
+ Hits 1901 1932 +31
- Misses 358 390 +32
Partials 2 2
|
MaikoTan
changed the title
<p> and <a> elements<p> and <a> and <br> elements
|
这个 PR 和下版本的一个更改冲突了。我先合了 PR，等之后再来写单测和 review 吧。 |
ilharp
changed the title
<p> and <a> and <br> elements<p> and <a> and <br> elements
ilharp
reviewed
Apr 5, 2024
There was a problem hiding this comment.
normalize() 里使用 reduce() 很帅，a 元素没问题了，不过 br 和 p 元素还是有点小问题。我加了几个单测，有谁愿意看看的话之后可以看一下（稍微有点难）。
https://github.com/chrononeko/chronocat/runs/23502779980
有打算解决单测的话，写好代码之后可以新开 PR。
Comment on lines
+116
to
+133
| case 'br': { | ||
| // 换行 | ||
| if (this.isEndLine) { | ||
| this.children.push(r.text('\n')) | ||
| } | ||
| this.isEndLine = false | ||
| return | ||
| } | ||
|
|
||
| case 'p': { | ||
| // 文本段落 | ||
| if (this.isEndLine) { | ||
| this.children.push(r.text('\n')) | ||
| } | ||
| await this.render(children) | ||
| this.isEndLine = true | ||
| return | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not tested (don't know how to test)