Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alloy style causes empty spelling suggestions for en-US, en-GB, en-AU and en-CA #3860

Closed
mol opened this issue Dec 25, 2024 · 5 comments
Closed
Labels
bug Bug report

Comments

@mol
Copy link

mol commented Dec 25, 2024

Describe the bug
No spelling suggestions for misspelled words are shown for en-US, en-GB, en-AU and en-CA, when running cefclient.exe with --use-alloy-style.

Other spell checker languages like da-DK, de-DE, en-GB-oxendict (surprisingly, since it's an English language), etc. still show suggestions.

To Reproduce

  1. Run cefclient.exe with --use-alloy-style command line argument.
  2. Go to https://www.calmlywriter.com/online
  3. Write "heg", followed by a space.
  4. Word should be highlighted as misspelled, but assuming language is en-US or another of the above, no spelling suggestions will be shown.

Expected behavior
Spelling suggestions should be shown.

Screenshots
image

Versions

  • OS: Windows 11
  • CEF Version: 131.3.5

Additional context
I first noticed this issue started happening after switching to a version of CefSharp where Alloy Bootstrap manipulation was removed, but for WPF, Alloy is still being used.

I've also noticed that when switching languages, the English language .bdic files, with the exception of en-GB-oxendict, often aren't downloaded to the cache's Dictionaries directory, but sometimes they are... Even without them however, spelling suggestions still work for those languages with off screen rendering disabled.

@mol mol added the bug Bug report label Dec 25, 2024
@mol mol changed the title Off screen rendering causes empty spelling suggestions for en-US, en-GB, en-AU and en-CA Alloy style causes empty spelling suggestions for en-US, en-GB, en-AU and en-CA Dec 29, 2024
@mol
Copy link
Author

mol commented Dec 29, 2024

Testing, it looks like it broke between 124.3.9 (last working version) and 125.0.22.

@magreenblatt
Copy link
Collaborator

Duplicate of #3055

@magreenblatt magreenblatt marked this as a duplicate of #3055 Jan 2, 2025
@magreenblatt magreenblatt closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2025
@mol
Copy link
Author

mol commented Jan 2, 2025

Duplicate of #3055

I don't believe it's a duplicate. Issue 3055 is 4 years old, and is describing the issue as spelling not being checked / marked with squiggly lines.

This issue started occurring recently, only for Alloy style, and squiggly lines do appear for misspelled words - it's just that no suggestions are shown to correct them for some languages - which seems to depend on the machine.

On one machine, en-UK doesn't show suggestions, but for another it does. I've tested this with two machines.

It seems they appear only for non-installed languages. So if you have en-UK installed on the machine, then suggestions won't appear.

I'm still working out the cause. Compiling with the flag to disable the machine spelling check part didn't seem to help.

All that said, I understand if it being an Alloy only issue means it's not something to fix, but I don't believe it's a duplicate 🙂

@magreenblatt
Copy link
Collaborator

magreenblatt commented Jan 2, 2025 via email

@mol
Copy link
Author

mol commented Jan 3, 2025

It seems they appear only for non-installed languages. So if you have en-UK installed on the machine, then suggestions won't appear.
This behavior is consistent with issue 3055, which is about missing Alloy support for the OS spell checker. Chromium is trying (and failing) to use the OS spell checker for installed languages. It is likely falling back to hunspell (which works) for non-installed languages.

Right, ok. I read through all of the comments there again, and I see what you're saying. It's just the description that's a bit inaccurate with the current state of the issue, but effectively this is a duplicate yeah 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report
Projects
None yet
Development

No branches or pull requests

2 participants