Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to depend on storybook instead of @storybook/cli #66

Conversation

tevanoff
Copy link
Contributor

Fixes AP-3573

What Changed

This is all from @thafryer's PR from chromaui/archive-storybook#15

We adjusted archive-storybook to depend on storybook instead of @storybook/cli.

How to test

Run the the archive-stroybook command with this package version and confirm the SB loads.

@tevanoff tevanoff changed the title depend on storybook rather than @storybook/cli Switch archive-storybook to depend on storybook instead of @storybook/cli Jan 16, 2024
@tevanoff tevanoff changed the title Switch archive-storybook to depend on storybook instead of @storybook/cli Switch to depend on storybook instead of @storybook/cli Jan 16, 2024
@thafryer thafryer force-pushed the jarel/ap-3573-switch-to-depending-on-storybook-instead-of-storybookcli branch from 1cc67ca to 21baca2 Compare January 17, 2024 00:37
tevanoff and others added 2 commits January 17, 2024 12:27
Co-authored-by: Jarel Fryer <jarelfryer@gmail.com>
@tevanoff tevanoff force-pushed the jarel/ap-3573-switch-to-depending-on-storybook-instead-of-storybookcli branch from 21baca2 to 21b691d Compare January 17, 2024 20:28
@thafryer thafryer requested review from skitterm and thafryer January 17, 2024 23:22
Copy link
Member

@skitterm skitterm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tevanoff can you add the ramifications to the PR description? I can't remember if this would remove the need for a build-script-name passed to npx chromatic, or what other reasons were behind this change.

Copy link
Member

@skitterm skitterm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tevanoff tevanoff merged commit 9abc77d into main Jan 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants