💄 Add an id to the inner iframe element used for E2E tests. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevanoff
reviewed
Nov 30, 2023
As part of CAP-1291, we need to have a unique identifier for this inner iframe. This adds said identifier.
jwir3
force-pushed
the
jwir3/CAP-1291-add-id-to-iframe
branch
from
6cccd15 to
67923b4
Compare
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of CAP-1291, we need to have a unique identifier for this inner iframe. This adds said identifier.
Issue: CAP-1291
What Changed
Added an id to the inner iframe element.
How to test
Open an E2E test storybook and verify that the inner iframe has an id on it.
Change Type
maintenancedocumentationpatchminormajor📦 Published PR as canary version:
0.0.18--canary.13.67923b4.0✨ Test out this PR locally via:
npm install @chromaui/archive-storybook@0.0.18--canary.13.67923b4.0 # or yarn add @chromaui/archive-storybook@0.0.18--canary.13.67923b4.0