Skip to content

[ENH]: add batch get version file paths method to Sysdb #4432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented May 3, 2025

Description of changes

Needed when garbage collecting a collection in a fork tree, because we need to read the version files of all other nodes in the tree.

Test plan

How are these changes tested?

Added a test.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

n/a

Copy link

github-actions bot commented May 3, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb force-pushed the feat-sysdb-batch-get-version-file-paths-method branch from ab87d31 to 7e6889e Compare May 5, 2025 19:36
Copy link
Contributor Author

codetheweb commented May 5, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codetheweb codetheweb force-pushed the feat-sysdb-batch-get-version-file-paths-method branch from 4d29f0d to 0d136b9 Compare May 8, 2025 23:30
Copy link
Contributor

Add Batch Get Version File Paths Method to SysDB

This PR adds a new method to SysDB that allows retrieving version file paths for multiple collections in a single call. This functionality is needed for garbage collection of collections in a fork tree, as it requires reading version files of all nodes in the tree.

Key Changes:
• Added new BatchGetCollectionVersionFilePaths method to SysDB
• Added new protobuf messages for request/response
• Implemented supporting code in Go and Rust

Affected Areas:
• SysDB Rust interface
• Go coordinator and database layers
• Protocol definitions (protobuf)

This summary was automatically generated by @propel-code-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants