Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an extendable template registry #995

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

bertdeblock
Copy link
Collaborator

The current "standard" is to provide an extendable template registry via <addon-name>/template-registry.

Usage:

import '@glint/environment-ember-loose';
import type FreestyleRegistry from 'ember-freestyle/template-registry';

declare module '@glint/environment-ember-loose/registry' {
  export default interface Registry extends FreestyleRegistry {
    // ...
  }
}

@bertdeblock bertdeblock force-pushed the provide-an-extendable-template-registry branch from 63e8087 to 184c588 Compare March 4, 2024 10:40
@bertdeblock bertdeblock requested a review from lukemelia March 4, 2024 10:47
Copy link
Collaborator

@lukemelia lukemelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I guess this would consitute a breaking change.

@lukemelia
Copy link
Collaborator

Looks good. I guess this would consitute a breaking change.

Which I see you have already labeled it as! 👍

@bertdeblock bertdeblock merged commit 42e0048 into master Mar 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants