-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarks #492
Comments
Results from choo 5 are here: https://rawgit.com/krausest/js-framework-benchmark/2923130afd1f85627ecac49fb9464dfa716fcbe4/webdriver-ts/table.html We're doing quite well on the memory side of things (super low overhead compared to vanilla DOM): But not so good in terms of CPU: Feel like with some basic optimizations (e.g. DOM node caching) we could find a better balance between the two (: |
Hi there @yoshuawuyts By adding choo@6 to krausest/js-framework-benchmark I might did a some baaaad publicity sorry 😮 Let me know how can I help :) |
Heya! — no worries haha; I'm not too worried about this benchmark, because
in real-world scenarios we tend to have fewer re-renders than most
alternatives.
The benchmark is probably right tho; we especially know that updating lots
of sibiling
nodes can be rather slow (which is the biggest metric in this benchmark).
When there's lots
of node in a tree, like in most applications, the results will probably be
more similar.
That said, we do have plans to improve this. We're currently working on an
update to our
diffing algorithm, so updates on long lists of sibling nodes become more
efficient. Check out
choojs/nanomorph#85 to track progress.
So thanks a lot for updating the benchmark! — I suspect it might need to be
updated once
again in the near future :P
…On Thu, Oct 26, 2017 at 2:14 PM Douglas Duteil ***@***.***> wrote:
Hi there @yoshuawuyts <https://github.com/yoshuawuyts>
By adding ***@***.*** to krausest/js-framework-benchmark
<krausest/js-framework-benchmark#260> I might did
a some baaaad publicity sorry 😮
[image: rawgit
com_krausest_js-framework-benchmark_15f11036046f06fa9de8cbf07dbac36a72c2e767_webdriver-ts-results_table
html 3]
<https://user-images.githubusercontent.com/730511/32054806-f4daee2a-ba5f-11e7-9ae8-380f5099a70a.png>
Let me know how can I help :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#492 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACWleq1VUO6BnXQIXJcO4yNfpBM4lsr_ks5swIWugaJpZM4NfDcj>
.
|
Would be cool if we worked with benchmark people to find pain points. If people want to help out, there's an open issue here: krausest/js-framework-benchmark#171 🎉
The text was updated successfully, but these errors were encountered: