-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(googlechrome) Change the api-url to use the stable version #2421
Conversation
✅ Package verification completed without issues. PR is now pending human review |
This was changed only a couple of weeks ago by @rdenny-vdc - can you comment on this? We can't keep updating this URL, so we need some clarity on what is the right thing to use (I have no horse in this race as I don't use Google Chrome). |
I 100% agree on this change, and it was something that was spoken about in the Chocolatey package comments here and I suggested this exact change. I support this change. Only thing I wasnt sure of was what would happen to package version numbering. |
The current url does not match the downloaded msi, no idea where you can download the extended version, but the stable url matches the msi-download. With the current url the version is several version behind. |
I'm confused as why you made the change to the extended release if you support it being on stable? This doesn't affect this PR, but I am concerned about the time it took to put the PR up, review the change, and now we're making another change. Trying to understand the why. |
I worked on the package to try and get it working again, I didnt know at the time there were two different versions at the time and trusted the information I was given. The full PR conversation is here. This was my first contribution. |
This change looks good to me, and I am happy to merge it. However:
There are two ways forward:
This is a very popular package so it's not one I want to 'wing it' on. |
@TheCakeIsNaOH would you be happy to help out? |
Having spoken to the team, everybody thinks this sounds like a reasonable change. Thanks @ralfbosz for your contribution! |
#2399 is the same fix as this one, but for |
The api-url used for Google Chrome is not the Google Chrome version that will be downloaded.
Description
The url is pointing to the extended releases. These are well behind and also not the version that will be downloaded from the url at this time (giving mismatch on hash). Move it to the stable-url which do match the downloaded msi.
Motivation and Context
How Has this Been Tested?
Screenshot (if appropriate, usually isn't needed):
Types of changes
Checklist:
Original Location