Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes mixed space and tab. Includes the project name to the HTML title. #11

Merged
merged 1 commit into from
Sep 29, 2016

Conversation

thedanheller
Copy link
Contributor

I love using this p5 manager. 2 things bother me, though. The broken indentation on the HTML file and the project name not being in the HTML title. I’ve made this quick fixing and implementation. Feel free to ignore them if you think it’s not relevant.

Thanks!

…tle.

- The HTML templates are mixing spaces and tabs, leaving to a broken
indentation. I’ve added a .editorconfig file and removed spaces on the
templates.
- Added the Project title to the HTML templates
@thedanheller
Copy link
Contributor Author

also feel free to change the .editorconfig as you like.

@chiunhau
Copy link
Owner

@daniloprates Thank you!!! I didn't notice these details before. ( I'm so surprised that you can understand my dirty code 😃

@thedanheller
Copy link
Contributor Author

Glad you liked it :)

@chiunhau chiunhau merged commit 1d4d217 into chiunhau:master Sep 29, 2016
@chiunhau
Copy link
Owner

This fix would be published soon.
Btw, I'm now working on issue #5. I think that .p5rc is not the best way to track projects...but I haven't come up with a alternative yet. Do you have any suggestion?

@thedanheller
Copy link
Contributor Author

What about a json file? So you could have more info about the project, eg

{
    "projects" : [
        {
            "name": "my project 1",
            "slug": "my-project-1",
            "libs": [
                "https://cdn.rawgit.com/generative-light/p5.scribble.js/master/p5.scribble.js"
            ]
        },
        {
            "name": "my project 2",
            "slug": "my-project-2",
            "libs": []
        }
    ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants