Skip to content

Commit

Permalink
Don't complain about vlog layering check in newer abseil.
Browse files Browse the repository at this point in the history
Essentially, allow to compile with newer abseil-cpp even though
we have to stay on an older version to honor older bazel versions.

Issues: #2336
  • Loading branch information
hzeller committed Jan 19, 2025
1 parent 3742532 commit 32abb43
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 0 deletions.
1 change: 1 addition & 0 deletions MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ bazel_dep(name = "rules_bison", version = "0.3")
# abseil-cpp and googletest can not be updated beyond the following currently,
# as newer googletest is not compatible with bazel 6 anymore, and abseil-cpp
# depends on it :( -- to support all active bazel's, we're stuck till EOL bazel6
# See https://github.com/chipsalliance/verible/issues/2336
bazel_dep(name = "googletest", version = "1.14.0.bcr.1", dev_dependency = True)

bazel_dep(name = "abseil-cpp", version = "20240116.2")
Expand Down
3 changes: 3 additions & 0 deletions verible/common/formatting/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@ cc_library(
"layout-optimizer-internal.h",
],
hdrs = ["layout-optimizer.h"],
# Can only add @abseil-cpp//absl/log:vlog_is_on after > absl 20240116
# https://github.com/chipsalliance/verible/issues/2336
features = ["-layering_check"],
deps = [
":basic-format-style",
":format-token",
Expand Down
6 changes: 6 additions & 0 deletions verible/verilog/analysis/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,9 @@ cc_library(
"verilog-analyzer.h",
"verilog-excerpt-parse.h",
],
# Can only add @abseil-cpp//absl/log:vlog_is_on after > absl 20240116
# https://github.com/chipsalliance/verible/issues/2336
features = ["-layering_check"],
deps = [
"//verible/common/analysis:file-analyzer",
"//verible/common/lexer:token-stream-adapter",
Expand Down Expand Up @@ -241,6 +244,9 @@ cc_library(
name = "verilog-linter",
srcs = ["verilog-linter.cc"],
hdrs = ["verilog-linter.h"],
# Can only add @abseil-cpp//absl/log:vlog_is_on after > absl 20240116
# https://github.com/chipsalliance/verible/issues/2336
features = ["-layering_check"],
deps = [
":default-rules",
":lint-rule-registry",
Expand Down
3 changes: 3 additions & 0 deletions verible/verilog/tools/ls/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,9 @@ cc_library(
name = "symbol-table-handler",
srcs = ["symbol-table-handler.cc"],
hdrs = ["symbol-table-handler.h"],
# Can only add @abseil-cpp//absl/log:vlog_is_on after > absl 20240116
# https://github.com/chipsalliance/verible/issues/2336
features = ["-layering_check"],
deps = [
":lsp-conversion",
":lsp-parse-buffer",
Expand Down

0 comments on commit 32abb43

Please sign in to comment.