-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Makefile target for python support testing and some README #901
Comments
2 tests are run when UHDM is compile with BUILD_SHARED_LIBS and test are run. (integrated to ctest framework) Line 47 in 04da4ce
Line 52 in 04da4ce
It seems to me that BUILD_SHARED_LIBS case is already integrated in workflow : UHDM/.github/workflows/main.yml Line 97 in eef0530
Do we need more ? |
I can't see this running in the Actions, can you point to an Action log that shows these tests are actually been executed in the CI? Also, please add a section in the README on how one would use this? (Set the compile option, run a test). |
https://github.com/chipsalliance/UHDM/actions/runs/4737059941/jobs/8409401013?pr=923#step:14:431 This aspect should be ok. Tests are run in the workflow now.
I add the required paragraph with python code given as example. In some way it contributes to #783 |
@Thomasb81 , Please add a top Makeflie test target for python:
make test_python
Also add the new target in the CI Action testing:
UHDM/.github/workflows/main.yml
Line 88 in eef0530
Also, please add some documentation in the README
The text was updated successfully, but these errors were encountered: