Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindAny should not look in the current instance for HighConn, only parent instance. #1074

Open
pieter3d opened this issue Feb 7, 2024 · 1 comment

Comments

@pieter3d
Copy link
Contributor

pieter3d commented Feb 7, 2024

See
chipsalliance/Surelog#3958 (comment)

In ElaboratorListener.cpp when bindAny is called and it comes from a port HighConn in VpiListener.cpp, searching for the net by name should not start at the top of the stack. Doing so will cause the HighConn to incorrectly reference the port net inside the module, if the net connected to the port (the desired high conn) has the same name as the port itself.

Assuming I'm not missing something here, this seems like a real bug and makes me wonder how this was never seen before.

@alaindargelas
Copy link
Collaborator

The instStack_ has to be popped temporarily while binding high_conn so is skips the current module scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants