user/hyfetch: new package (1.4.11) #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekopsykose
reviewed
Jul 11, 2024
user/hyfetch/template.py
Outdated
| depends = [ | ||
| "bash", | ||
| "python-setuptools", | ||
| "python-typing_extensions", |
There was a problem hiding this comment.
Suggested change
| "python-typing_extensions", |
backport this hykilpikonna/hyfetch@359226c
nekopsykose
reviewed
Jul 11, 2024
nekopsykose
reviewed
Jul 11, 2024
|
@nekopsykose good morning, I understand the reason to change but isn't it better to package with the author's original description? Here some packages:
Thanks for the quick review, I'll fix those lints errors soon on my lunch break and if not replied by then I'll also change the description as suggested. |
|
hykilpikonna/hyfetch#285 maybe drop in this? seems to work fine (just make a patches/ dir and drop in https://patch-diff.githubusercontent.com/raw/hykilpikonna/hyfetch/pull/285.patch) |
|
as for the pkgdesc i'm fine with either one but i'd drop the exclamation mark regardless since that's in line with punctuation use in any other pkgdesc in the repository |
cassiofb-dev
force-pushed
the
hyfetch
branch
4 times, most recently
from
d67e4fd to
c8db5da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly it does not support chimera yet but users can configure to their liking.