1756 add button to remove holds on an item #1835
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds a new button to the admin/item's holds view so that individual holds may be ended. Originally the ticket discussed removing the hold entirely but after some discussion it was decided to set the
ended_atattribute so our future selves may benefit from the data.Why it is important
This would resolve #1756
UI Change Screenshot
BEFORE
AFTER
Implementation notes
This is my first PR on this project, and my return to coding after taking a year sabbatical, so just a heads-up I
may beam rusty and appreciate and feedback.One thing to confirm is the new "actions" column (see screenshot). In other apps I've worked on in the past we've used this column for a general one-size-fits-all place to put actions. Let me know if there is another solution we'd like to use.