Capture misc metadata from imported items in a column #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crismali
approved these changes
Feb 4, 2025
| @@ -0,0 +1,5 @@ | |||
| class AddMyturnMetaToReservableItems < ActiveRecord::Migration[7.2] | |||
| def change | |||
| add_column :reservable_items, :myturn_metadata, :jsonb, default: "{}" | |||
There was a problem hiding this comment.
Might want to double check, but does the default of "{}" actually wind up as literally a string?
There was a problem hiding this comment.
You're right, it does end up as a string. Using a plain empty Hash works as intended, though. Good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds a new
jsonbcolumn toreservable_itemsto store arbitrary key/value metadata from imported items. This gives us a way to persist some data that doesn't map cleanly into our schema for future use. One example is that this gives us a way to capture the image URL for each item that we can later fetch and store properly.