Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Loan#open_days #1212

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Update Loan#open_days #1212

merged 1 commit into from
Dec 1, 2023

Conversation

jim
Copy link
Member

@jim jim commented Dec 1, 2023

What it does

As of December 1, 2023, CTL will be open Thursday, Friday, and Saturday. This PR updates the return value of Loan#open_days, which is used by Loan#next_open_day when calculating when a loan (or renewal) should be due.

Why it is important

  • Without this change, the app will create loans that are due on days we're not open. This is confusing and creates more communication overhead for everyone.

Your bandwidth for additional changes to this PR

Please choose one of the following to help the project maintainers provide the appropriate level of support:

  • I have the time and interest to make additional changes to this PR based on feedback.
  • I am interested in feedback but don't need to make the changes myself.
  • I don't have time or interest in making additional changes to this work.
  • Other or not sure (please describe):

@jim jim changed the title Update the open days Update Loan#open_days Dec 1, 2023
@jim jim merged commit 2e49579 into main Dec 1, 2023
@jim jim deleted the jim-update-hours-december-2023 branch December 1, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant