Skip to content

Commit

Permalink
Fix erblint errors stemming from standard upgrade.
Browse files Browse the repository at this point in the history
  • Loading branch information
jim committed Nov 28, 2023
1 parent 117d8a1 commit ac7b95b
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion app/views/account/appointments/_form.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
<div class="form-group" data-controller="appointment-date">
<label class="form-label h3" for="time_range_string">Select a time for the appointment</label>
<%= select("appointment", "time_range_string", grouped_options_for_select(@appointment_slots, @appointment.time_range_string), {include_blank: "Select a Date"},
class: "form-select", data: {action: "appointment-date#sync", 'appointment-date-target': "select"}, disabled: !can_schedule_appointment) %>
class: "form-select", data: {action: "appointment-date#sync", "appointment-date-target": "select"}, disabled: !can_schedule_appointment) %>
<span data-appointment-date-target="display"></span>
<p>Don't worry if you arrive a little bit early or late, as long as it's within the library's open hours.</p>
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/views/admin/appointments/_form.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<div class="form-group" data-controller="appointment-date">
<label class="form-label" for="time_range_string">Select an appointment time</label>
<%= select("appointment", "time_range_string", grouped_options_for_select(@appointment_slots, @appointment.time_range_string), {include_blank: "Select a Date"},
class: "form-select", data: {action: "appointment-date#sync", 'appointment-data-target': "select"}) %>
class: "form-select", data: {action: "appointment-date#sync", "appointment-data-target": "select"}) %>
<span data-appointment-date-target="display"></span>
</div>

Expand Down
4 changes: 2 additions & 2 deletions app/views/admin/images/edit.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
<div class="image-editor">
<div class="image-editor-row">
<a href="#" class="rotation-control left" data-action="image-editor#left"></a>
<%= image_tag url_for(@image.variant(resize_to_limit: [400, 280])), data: {'image-editor-target': "image"} %>
<%= image_tag url_for(@image.variant(resize_to_limit: [400, 280])), data: {"image-editor-target": "image"} %>
<a href="#" class="rotation-control right" data-action="image-editor#right"></a>
</div>
</div>
<%= f.submit "Save" %>
<%= f.hidden_field :rotation, value: @image.metadata["rotation"], data: {'image-editor-target': "field"} %>
<%= f.hidden_field :rotation, value: @image.metadata["rotation"], data: {"image-editor-target": "field"} %>
<% end %>
<% end %>
4 changes: 2 additions & 2 deletions app/views/admin/items/_form.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@
<%= form.select :status, options_for_select(item_status_options, item.status || Item.statuses[:active]), prompt: true, hint: "Only active items can be checked out" %>
</div>
<div class="column col-4 col-sm-12">
<%= form.select :borrow_policy_id, options_for_select(borrow_policy_options, item.borrow_policy_id || BorrowPolicy.default&.id), {hint: "Borrowing rules used for this item"}, data: {action: "conditional-field#change", 'conditional-field-target': "parent"} %>
<%= form.select :borrow_policy_id, options_for_select(borrow_policy_options, item.borrow_policy_id || BorrowPolicy.default&.id), {hint: "Borrowing rules used for this item"}, data: {action: "conditional-field#change", "conditional-field-target": "parent"} %>
</div>
<div class="column col-4 col-sm-12">
<%= tag.div data: {'conditional-field-target': "child"}, class: "conditional-field-child" do %>
<%= tag.div data: {"conditional-field-target": "child"}, class: "conditional-field-child" do %>
<%= form.text_field :quantity, label: "Approximate quantity", hint: "Just an estimate for planning purposes" %>
<% end %>
</div>
Expand Down
4 changes: 2 additions & 2 deletions app/views/admin/items/attachments/_form.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
<%= form.file_field :file %>

<div data-controller="conditional-field" data-conditional-field-trigger="other">
<%= form.select :kind, options_for_select(item_attachment_kind_options, attachment.kind), {}, data: {action: "conditional-field#change", 'conditional-field-target': "parent"} %>
<%= tag.div data: {'conditional-field-target': "child"}, class: "conditional-field-child nested" do %>
<%= form.select :kind, options_for_select(item_attachment_kind_options, attachment.kind), {}, data: {action: "conditional-field#change", "conditional-field-target": "parent"} %>
<%= tag.div data: {"conditional-field-target": "child"}, class: "conditional-field-child nested" do %>
<%= form.text_field :other_kind, placeholder: "Please specify" %>
<% end %>
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/views/admin/members/appointments/_form.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<div class="form-group" data-controller="appointment-date">
<label class="form-label" for="time_range_string">Select an appointment time to create an appointment for this member</label>
<%= select("appointment", "time_range_string", grouped_options_for_select(@appointment_slots, nil), {include_blank: "Select a Date"},
class: "form-select", data: {action: "appointment-date#sync", 'appointment-date-target': "select"}) %>
class: "form-select", data: {action: "appointment-date#sync", "appointment-date-target": "select"}) %>
<span data-appointment-date-target="display"></span>
</div>
<div class="form-buttons">
Expand Down
2 changes: 1 addition & 1 deletion app/views/admin/members/verifications/edit.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<fieldset>
<legend>Activate <%= @member.preferred_name %>'s Membership</legend>
<div data-controller="conditional-field" data-conditional-field-trigger="other_id_kind">
<%= form.select :id_kind, options_for_select(member_id_kind_options, form.object.id_kind), {prompt: true, label: "Photo ID"}, data: {action: "conditional-field#change", 'conditional-field-target': "parent"} %>
<%= form.select :id_kind, options_for_select(member_id_kind_options, form.object.id_kind), {prompt: true, label: "Photo ID"}, data: {action: "conditional-field#change", "conditional-field-target": "parent"} %>
<%= tag.div data: {"conditional-field-target": "child"}, class: "conditional-field-child nested" do %>
<%= form.text_field :other_id_kind, label: "Other ID Type", placeholder: "Please specify" %>
<% end %>
Expand Down

0 comments on commit ac7b95b

Please sign in to comment.