Fix loading issue in SearchHost.exe and providing display attribute #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Init code in DllMain might cause dead lock. Fix and refactor the code to remove all static module reference. Static link libchewing because SearchHost.exe runs in different security context and overrides DLL search order, which breaks loading chewing-msvc.dll.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#213 #219
DllMain 中的初始化程式碼可能導致死鎖。修正並重構程式碼以移除所有靜態模組參考。
由於 SearchHost.exe 在不同的安全性環境下執行並覆寫 DLL 搜尋順序（這會導致 chewing-msvc.dll 載入失敗），因此改為靜態連結 libchewing。
#217
微軟文件裡面寫的 DisplayAttribute 提供方式跟實際上實做不太一樣，會直接使用 Text Service 取得 ITfDisplayAttributeProvider
重構之後可以正確提供 DisplayAttribute，應該就不會變成黑色了。