Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structures with multiple fragments #6

Open
RicardoSilvestr opened this issue Mar 20, 2023 · 2 comments
Open

structures with multiple fragments #6

RicardoSilvestr opened this issue Mar 20, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@RicardoSilvestr
Copy link
Contributor

It appears that we overlooked the fact that structures can consist of multiple fragments. When this occurs, both atoms and unsaturations are included within the mfInfo.parts property as an array that contains the corresponding information for each fragment.

Given that atoms are stored as text data, I created a workaround by converting an array of atoms (e.g., [{atoms1},{atoms2}]) into a string. However, the issue with unsaturations, which are stored as integers, presents a more significant challenge. Currently, the highest value of all fragments is being used (as of 20.03.23), but this is not a permanent solution.

We need to find a more comprehensive solution that addresses the unsaturation problem.

@RicardoSilvestr RicardoSilvestr added the bug Something isn't working label Mar 20, 2023
@RicardoSilvestr RicardoSilvestr self-assigned this Mar 20, 2023
RicardoSilvestr added a commit that referenced this issue Mar 20, 2023
@lpatiny
Copy link
Member

lpatiny commented Mar 20, 2023

I think if fragment>1 we should just ignore unsaturation and atoms.

image

@lpatiny
Copy link
Member

lpatiny commented Mar 21, 2023

Finally we will add the sum. A new version of mass-tools will be released to calculate the sum in case there are any parts: cheminfo/mass-tools@b96a6d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants