Skip to content

Commit 2b920c4

Browse files
author
Jesper Lindstrøm Nielsen
committed
Call 'Finish' when the wrapped Reader or Writer is closed
1 parent c966da0 commit 2b920c4

File tree

5 files changed

+8
-0
lines changed

5 files changed

+8
-0
lines changed

go.mod

+2
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,5 @@ require (
66
github.com/mattn/go-runewidth v0.0.4
77
golang.org/x/sys v0.0.0-20190626221950-04f50cda93cb
88
)
9+
10+
go 1.13

reader.go

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ func (r *Reader) Read(p []byte) (n int, err error) {
1818

1919
// Close the reader when it implements io.Closer
2020
func (r *Reader) Close() (err error) {
21+
r.bar.Finish()
2122
if closer, ok := r.Reader.(io.Closer); ok {
2223
return closer.Close()
2324
}

v3/go.mod

+2
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,5 @@ require (
77
github.com/mattn/go-isatty v0.0.8
88
github.com/mattn/go-runewidth v0.0.4
99
)
10+
11+
go 1.13

v3/io.go

+2
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ func (r *Reader) Read(p []byte) (n int, err error) {
1919

2020
// Close the wrapped reader when it implements io.Closer
2121
func (r *Reader) Close() (err error) {
22+
r.bar.Finish()
2223
if closer, ok := r.Reader.(io.Closer); ok {
2324
return closer.Close()
2425
}
@@ -40,6 +41,7 @@ func (r *Writer) Write(p []byte) (n int, err error) {
4041

4142
// Close the wrapped reader when it implements io.Closer
4243
func (r *Writer) Close() (err error) {
44+
r.bar.Finish()
4345
if closer, ok := r.Writer.(io.Closer); ok {
4446
return closer.Close()
4547
}

writer.go

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ func (r *Writer) Write(p []byte) (n int, err error) {
1818

1919
// Close the reader when it implements io.Closer
2020
func (r *Writer) Close() (err error) {
21+
r.bar.Finish()
2122
if closer, ok := r.Writer.(io.Closer); ok {
2223
return closer.Close()
2324
}

0 commit comments

Comments
 (0)