Client::request did not load X509 cert correctly

[ralian]

When loading a custom X509 cert in Client::request, the gem attempted to call OpenSSL::PKey::RSA.new with the raw content of the key file which either no longer works or never worked.

Description

Simply assign the RSA key by using the OpenSSL gem's built in member OpenSSL::X509::Certificate::public_key instead of calling OpenSSL::PKey::RSA.new.

Related Issue

#172

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
• All new and existing tests passed.
• All commits have been signed-off for the Developer Certificate of Origin.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[ralian]

I haven't bothered with setting the unit tests up as they don't really even cover this case. Do let me know if there's anything else I need to test before this can be merged.

I also think this falls under an 'obvious fix' in the DCO, but I didn't add that to my commit message at the time.