Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rexml as an explicit runtime dependency #169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Fs00
Copy link

@Fs00 Fs00 commented Oct 19, 2023

Description

rexml is a bundled gem since Ruby 3, which means that it needs to be added to the gemspec/Gemfile in order to be required.

The lack of the explicit dependency caused the error LoadError: cannot load such file -- rexml/document in our staging/prod environments, which has been tricky to debug because in dev environments we have test dependencies that depend on rexml and therefore mitigate its absence in the artifactory gemspec.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Francesco Saltori <francescosaltori@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Fs00
Copy link
Author

Fs00 commented Oct 19, 2023

CI failures on older Rubies appear to be unrelated to this change.

@Fs00 Fs00 mentioned this pull request Jun 23, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant